Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure monitoring for custom error pages #3143

Merged
merged 2 commits into from
Sep 26, 2018

Conversation

Globegitter
Copy link
Contributor

What this PR does / why we need it: This should fix missing metrics when custom error pages are activated

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #3140

Special notes for your reviewer: I am not super familiar with the lua setup but hope that should do it.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 26, 2018
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 26, 2018
@aledbf
Copy link
Member

aledbf commented Sep 26, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 26, 2018
@aledbf
Copy link
Member

aledbf commented Sep 26, 2018

@Globegitter thanks!

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2018
@Globegitter
Copy link
Contributor Author

Ah, I used the $all incorrectly in this part of the template it seems. Should be fixed now.

@codecov-io
Copy link

Codecov Report

Merging #3143 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3143   +/-   ##
=======================================
  Coverage   47.68%   47.68%           
=======================================
  Files          77       77           
  Lines        5708     5708           
=======================================
  Hits         2722     2722           
  Misses       2630     2630           
  Partials      356      356

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f56e839...a2ccd1f. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Sep 26, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, Globegitter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5ba5ddf into kubernetes:master Sep 26, 2018
@Globegitter Globegitter deleted the patch-2 branch September 26, 2018 15:00
@Globegitter
Copy link
Contributor Author

@aledbf thanks for the quick response, do you think it would be possible to have a patch release for this fix? Or even if there is just a nightly/dev build that would also work to have the fix already in place until the next release.

@aledbf
Copy link
Member

aledbf commented Sep 26, 2018

@Globegitter sure, use quay.io/kubernetes-ingress-controller/nginx-ingress-controller:dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nginx_ingress_controller_requests metrics not collecting statuses with custom error page
4 participants