Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved X-Auth-Request-Redirect back into correct location block for oa… #2028

Closed

Conversation

kinghrothgar
Copy link
Contributor

@kinghrothgar kinghrothgar commented Feb 2, 2018

…uth2_proxy

What this PR does / why we need it:
This fixes an infinite sign in loop when using oauth2_proxy as external auth created by #1472 and discussed more in bitly/oauth2_proxy#427. More explanation can be found in the comment of my work mate here: #1472 (comment)

I'm not sure if this is the best way to fix this but we need some fix in so we can get it working.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 2, 2018
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kinghrothgar
We suggest the following additional approver: caseydavenport

Assign the PR to them by writing /assign @caseydavenport in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 2, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 39.742% when pulling aa770f56ac6b421ae6a988c2a812c91f2714043d on kinghrothgar:fixXAuthRequestRedirect into ad2238c on kubernetes:master.

@kinghrothgar kinghrothgar force-pushed the fixXAuthRequestRedirect branch from aa770f5 to c2fc3f0 Compare February 5, 2018 15:43
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 6, 2018
@aledbf aledbf closed this May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants