This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
Allow redirect URL to be passed in the query string. #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update on this? |
|
|
@ploxiln is possible a redirect to a different host? |
|
see #399 |
|
@ploxiln ok, so the recommendation is to not allow "external" redirects or adding the whitelist domain flag is ok? |
|
A domain whitelist feature would be as good as the current status-quo from a security/phishing perspective. It's just arbitrary (completely unrestricted) redirect domain which is problematic. |
Closed
boivie
added a commit
to boivie/oauth2_proxy
that referenced
this pull request
Sep 30, 2017
In addition to the X-Auth-Request-Redirect header, which still has precedence. Fixes bitly#427
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the Kubernetes nginx ingress controller, the sign_in page is reached via a 302 redirect, which means that we cannot use the
X-Auth-Request-Redirectheader. Instead, we need to be able to include the URL in the query string.