Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Job Success Policy - add a GA graduation point to verify success reason in conformance tests #4851

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Job Success Policy - add a GA graduation point to verify success reason in conformance tests #4851

merged 1 commit into from
Sep 16, 2024

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented Sep 13, 2024 •
edited
Loading

One-line PR description: Add a graduation point to verify reason for the Job's complete condition

Issue link: #3998

Other comments:

  • The update was prompted by the comment
  • We don't verify currently the reason for the Complete condition in conformance tests, as the conformance suite does not enable beta features (including "Success Policy" feature which changed the reason for the condition)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Sep 13, 2024
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 13, 2024
@mimowo
Copy link
Contributor Author

mimowo commented Sep 13, 2024

/sig apps
/cc @atiratree @alculquicondor @soltysh @tenzen-y

@mimowo mimowo mentioned this pull request Sep 13, 2024
Merged
@mimowo mimowo changed the title Job Success Policy - add a GA graduation point Job Success Policy - add a GA graduation point to verify success reason in conformance tests Sep 13, 2024
@alculquicondor
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2024
tenzen-y
tenzen-y reviewed Sep 13, 2024
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@mimowo
Copy link
Contributor Author

mimowo commented Sep 16, 2024

/assign @soltysh

soltysh
soltysh approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit c383950 into kubernetes:master Sep 16, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@soltysh soltysh soltysh approved these changes

@kow3ns kow3ns Awaiting requested review from kow3ns

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@atiratree atiratree Awaiting requested review from atiratree

Assignees

@soltysh soltysh

@alculquicondor alculquicondor

@tenzen-y tenzen-y

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Apps
Archived in project
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
5 participants
@mimowo @alculquicondor @k8s-ci-robot @soltysh @tenzen-y