Job success/completion policy

[tenzen-y]

Enhancement Description

• One-line enhancement description (can be used as a release note): An API to define when a Job can be declared as succeeded based on the number of succeeded pods.
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/3998-job-success-completion-policy
• Discussion Link: Job success/completion policy kubernetes#117600
• Primary contact (assignee): @tenzen-y
• Responsible SIGs: sig-apps
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): v1.30
  • Beta release target (x.y): v1.31
  • Stable release target (x.y):
• Alpha
  • KEP (k/enhancements) update PR(s):
    • KEP-3998: Job success/completion policy #4062
    • KEP-3998: Uptdate JobSuccessPolicy API Name and Validations #4537
  • Code (k/k) update PR(s):
    • Job: Support for the SuccessPolicy kubernetes#123412
    • Job: Use the fake clock in TestTrackJobStatusAndRemoveFinalizers kubernetes#123826
  • Docs (k/website) update PR(s):
    • Add JobSuccessPolicy Doc website#45135
    • KEP-3998: Rephrase JobSuccessPolicy documentations website#45677
• Beta
  • KEP (k/enhancements) update PR(s):
    • KEP-3998: Graduate Job SuccessPolicy to Beta #4702
    • KEP-3998: Update the metrics and condition reason for the Beta graduation #4775
  • Code (k/k) update PR(s):
    • Job: Fix a bug that the SuccessCriteriaMet could be added to the Job with successPolicy regardless of the featureGate enabling kubernetes#125429
    • Job: Add the CompletionsReached reason to the SuccessCriteriaMet condition kubernetes#126074
    • Job: Introduce a new job_suceeded_total metric kubernetes#126075
    • Graduate the JobSuccessPolicy to beta kubernetes#126064
    • Graduate the JobSuccessPolicy to Beta kubernetes#126067
  • Docs (k/website) update PR(s): Update JobSuccessPolicy documentations for the beta graduation website#46970
• Stable
  • KEP (k/enhancements) update PR(s):
  • Code (k/k) update PR(s):
  • Docs (k/website) update(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

/sig apps
/wg batch
/assign

[alculquicondor]

@soltysh I'm not sure if this will make it to the enhancements freeze, but would you consider a lead-opted-in?

[soltysh]

@soltysh I'm not sure if this will make it to the enhancements freeze, but would you consider a lead-opted-in?

Sorry, I won't be able to get there before today's freeze

[tenzen-y]

Since many discussions are left, I will try to complete it for the next release cycle (v1.29).
Thanks to everyone!

[dejanzele]

Hey @tenzen-y,

Are you still working on this KEP?

I just finished graduation of the PodReplacementPolicy to Beta and I have capacity to take on additional work if you don't have capacity to work on this KEP.

[tenzen-y]

KEP-3998: Job success/completion policy #4062

I'm working on this now. I will move this forward in the next release cycle (v1.30) since the enhancement freeze for this release (v1.29) came.

#4062 (comment)

[kannon92]

@soltysh since the KEP is being reviewed, did you consider adding this as a feature for sig-apps for 1.30?

[soltysh]

/label lead-opted-in
/milestone v1.30
/stage alpha

[pnbrown]

Hello @tenzen-y 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage alpha for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.30.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

• Make sure the PR with the information get merged before enhancement freeze, I just found this PR.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[tenzen-y]

@pnbrown Thank you for contacting me.

This enhancement is targeting for stage stable for v1.30 (correct me, if otherwise)

This enhancement is still targeting for alpha stage. Could you confirm again?

[pnbrown]

That's my mistake. Editing now

[tenzen-y]

That's my mistake. Editing now

Thanks.

[pnbrown]

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

[celestehorgan]

Hi @tenzen-y!

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

[tenzen-y]

Hi @tenzen-y!

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

Sure. Thank you for reminding me!
Created: kubernetes/website#45135

[natalisucks]

Hi @tenzen-y,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.

Here's the 1.30 Release Calendar

[tenzen-y]

Hi @tenzen-y,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository. The placeholder PR deadline is 27th February, 2024.

Here's the 1.30 Release Calendar

@natalisucks Hi, thank you for contacting me. I created a placeholder PR here: kubernetes/website#45274.

[carlory]

@prianna I raised a PR to promote it to beta.

[carlory]

@tenzen-y is working on both tasks. kubernetes/kubernetes#126017 (comment)
cc @prianna I closed my PR.

[tenzen-y]

@prianna I updated the code list in this description.

[prianna]

@tenzen-y @carlory Thank you for raising the PRs and updating the issue description. I'll keep an eye on this for merges for the following PRs:

• Job: Add the CompletionsReached reason to the SuccessCriteriaMet condition kubernetes#126074
• Job: Introduce a new job_suceeded_total metric kubernetes#126075
• Graduate the JobSuccessPolicy to beta kubernetes#126064
• Graduate the JobSuccessPolicy to Beta kubernetes#126067

Wishing you expediency of reviews and many passing tests.

[tenzen-y]

@prianna Hi, Prianna. All codes (k/k) have already been merged.

[sreeram-venkitesh]

Thanks @tenzen-y! Marking this KEP as tracked for code freeze 🎉

[sreeram-venkitesh]

@tenzen-y I found a PR related to this KEP: kubernetes/kubernetes#121863 (comment). You've mentioned earlier in the PR that the PR was related to the beta graduation of this KEP. Is that taken care of, or are there any pending changes that affect this KEP?

Please let us know as we are in code freeze now, thanks!

[carlory]

FYI @sreeram-venkitesh kubernetes/kubernetes#126017 (comment)

[tenzen-y]

@tenzen-y I found a PR related to this KEP: kubernetes/kubernetes#121863 (comment). You've mentioned earlier in the PR that the PR was related to the beta graduation of this KEP. Is that taken care of, or are there any pending changes that affect this KEP?

Please let us know as we are in code freeze now, thanks!

Sorry for your confusion. As @carlory mentioned above, there is kubernetes/kubernetes#121863 bug before we introduce the JobSuccessPolicy. So, I'm trying to fix the bug separate from this KEP.
Once I get approval from sig apps approvers, I will contact release team members as a separate issue.

[sreeram-venkitesh]

No worries @tenzen-y! Thanks a lot for the clarification.

Once I get approval from sig apps approvers, I will contact release team members as a separate issue.

Does this PR needs to go in the v1.31 release? If its not related to the KEP, we are good here. You can reach out later once you get the approval.

[tenzen-y]

No worries @tenzen-y! Thanks a lot for the clarification.

Once I get approval from sig apps approvers, I will contact release team members as a separate issue.

Does this PR needs to go in the v1.31 release? If its not related to the KEP, we are good here. You can reach out later once you get the approval.

Yes, kubernetes/kubernetes#121863 is not related to this Enhancement.

[tjons]

Hi, enhancements lead here - I inadvertently added this to the 1.32 tracking board 😀. Please readd it if you wish to progress this enhancement in 1.32.

/remove-label lead-opted-in

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[tenzen-y]

/remove-lifecycle stale