Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: 4176: update milestones for 1.31 #4731

Closed
wants to merge 1 commit into from

Conversation

ffromani
Copy link
Contributor

  • One-line PR description: update kep.yaml for 1.31
  • Other comments:

Reflect the current state of work as kube 1.31

Signed-off-by: Francesco Romani <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 14, 2024
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 14, 2024
@Jeffwan
Copy link
Contributor

Jeffwan commented Jun 14, 2024

Looks good to me.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ffromani, Jeffwan
Once this PR has been reviewed and has the lgtm label, please assign dchen1107 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bart0sh
Copy link
Contributor

bart0sh commented Jul 20, 2024

/lgtm

/cc @mrunalp @dchen1107 @derekwaynecarr
for approval

@k8s-ci-robot k8s-ci-robot requested a review from mrunalp July 20, 2024 17:56
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2024
@bart0sh bart0sh removed their assignment Jul 20, 2024
@pacoxu
Copy link
Member

pacoxu commented Oct 12, 2024

/cc @mrunalp @dchen1107 @derekwaynecarr
for approval

/lgtm
this is just milestone sync(which was done in v1.31)

alpha: "v1.30"
beta: "v1.31"
alpha: "v1.31"
beta: "v1.32"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As no PRR review or KEP update happened before v1.32 enhancements freeze, this is missed.

-  alpha: "v1.31"

The alpha update is valid. beta may be 1.33 or later.

@pacoxu
Copy link
Member

pacoxu commented Oct 12, 2024

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2024
@kannon92
Copy link
Contributor

/close

Feel free to open this up once this is actively worked on for 1.33.

@k8s-ci-robot
Copy link
Contributor

@kannon92: Closed this PR.

In response to this:

/close

Feel free to open this up once this is actively worked on for 1.33.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Development

Successfully merging this pull request may close these issues.

6 participants