New Static Policy Proposal - Spread HT across physical CPUs

[Jeffwan]

Enhancement Description

• One-line enhancement description (can be used as a release note): VPA + core binding
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/4176-cpumanager-spread-cpus-preferred-policy/README.md
• Discussion Link: https://docs.google.com/document/d/1V3DLh3pH3CD-xhhJvAnOq_oWgPyjO-vj6wY6qdew9H0/edit#heading=h.ybybfdfputt
• Primary contact (assignee): @Jeffwan
• Responsible SIGs: sig-node
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.31
  • Beta release target (x.y): 1.33?
  • Stable release target (x.y): 1.35
• Alpha
  • KEP (k/enhancements) update PR(s): KEP-4176: A Static Policy Option to spread hyperthreads across physical CPUs #4177
    • node: 4176: update milestones for 1.31 #4731
  • Code (k/k) update PR(s): KEP-4176: Add a new static policy SpreadPhysicalCPUsPreferredOption kubernetes#123733
  • Docs (k/website) update PR(s): Add docs for KEP-4176 new static policy DistributeCPUsAcrossCores website#47014 (comment)

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[Jeffwan]

/sig node

[ffromani]

/cc

[SergeyKanzhelev]

/stage alpha
/milestone v1.29

Applying the milestone as discussed at SIG Node meeting this week

[npolshakova]

Hello @Jeffwan, 1.29 Enhancements team here! Is this enhancement targeting 1.29? If it is, can you follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board? Thanks!

[salehsedghpour]

Hello 👋 1.30 Enhancements Lead here,

I'm closing milestone 1.29 now,
If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

[Jeffwan]

Sounds good. I will follow the instruction and move it to v1.30. We plan to polish it for further review.

[Jeffwan]

@salehsedghpour This is the initial issue and the PR is not merged yet. Could you help add v1.30 milestone? @SergeyKanzhelev @ffromani We will put some time to address all the comments recently

[salehsedghpour]

Thanks for the info @Jeffwan, may you please follow it up so that you could also have the lead-opted-in label and the milestone with the SIG leads?

[SergeyKanzhelev]

/stage alpha
/milestone v1.30

As discussed this is conditioned on the discussion on whether NRI approach will work better for this scenario

[mrunalp]

/label lead-opted-in

[jpbetz]

PRR reviewer here, is there a KEP PR for 1.30 for this enhancement?

[Jeffwan]

@jpbetz I see you've already left comments in the PR. #4177 Let's discuss more details there.

[sreeram-venkitesh]

Hello @Jeffwan 👋, v1.30 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage alpha for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we need to do the following:

• Update the latest-milestone here in the kep.yaml to 1.30
• Update the alpha milestone to 1.30 instead of 1.29.
• Make sure to create the prod-readiness/<sig>/<KEP number>.yaml file as mentioned by @jpbetz here. More about

The status of this enhancement is marked as At risk for enhancements freeze. Please make sure to do all the above tasks and get your PRs merged before the enhancements freeze. Please let us know if you have any questions!

[Jeffwan]

@sreeram-venkitesh Thanks for the reminder. All the TODO items have been addressed and it's pending review.

[sreeram-venkitesh]

Hello 👋, v1.30 Enhancements team here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in v1.30, please file an exception request. Thanks!

[salehsedghpour]

/milestone clear

[Jeffwan]

@sreeram-venkitesh @salehsedghpour I filed an exception and waiting for sig-node to approve it.

[Jeffwan]

@mickeyboxell Thanks for reviewer's responsive feedback. kubernetes/kubernetes#123733 has been merged. I will finish the doc PR by end of week as well

[LaurentGoderre]

@Jeffwan can you add the docs PR in this issue description

kubernetes/website#47014

[Jeffwan]

@LaurentGoderre done. Once the doc PR is merged, all three tasks for alpha release should be done.

[mickeyboxell]

Hi @Jeffwan 👋, Enhancements team here.

With all the implementation (code related) PRs merged as per the issue description:

• KEP-4176: Add a new static policy SpreadPhysicalCPUsPreferredOption kubernetes#123733

This enhancement is now marked as tracked for code freeze for the v1.31 Code Freeze!

[kannon92]

@Jeffwan we are getting ready for 1.32 planning. Are you interested in promoting this feature to beta in 1.32?

[tjons]

Hi, enhancements lead here - I inadvertently added this to the 1.32 tracking board 😀. Please readd it if you wish to progress this enhancement in 1.32.

/remove-label lead-opted-in

[haircommander]

/milestone v1.32
/label lead-opted-in

[tjons]

Hello @Jeffwan 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage beta for v1.32 (correct me, if otherwise).

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: v1.32.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday, October 3rd, 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

• KEP status is marked as implementable for latest-milestone: v1.32.
• KEP has a production readiness review that has been completed and merged into k/enhancements.
• Update the KEP to use the latest template and add beta graduation criteria. There are several required sections missing: Motivation, Alternatives, and Implementation history. Please ensure that all required sections (not marked Optional in https://github.com/kubernetes/enhancements/blob/master/keps/NNNN-kep-template/README.md`) are present.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

[jpbetz]

PRR reviewer here. Is this still targeting v1.32? The PRR deadline is Thursday. Is there anything I can review?

[kannon92]

@Jeffwan Please respond. Otherwise, we will not consider this KEP for this release.

[kannon92]

Given the above, I am going to assume that this feature will no longer be tracked for 1.32. Please bring this feature up for 1.33.

[tjons]

/milestone clear
/remove-label lead-opted-in