Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3935: newest control planes support oldest nodes #3936

Merged
merged 10 commits into from
May 5, 2023
Merged

KEP-3935: newest control planes support oldest nodes #3936

merged 10 commits into from
May 5, 2023

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Apr 3, 2023 •
edited
Loading

  • One-line PR description: initial draft of KEP-3935: Support Oldest Node With Newest Control Plane

Approvers:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 3, 2023
@liggitt liggitt changed the title KEP-3935: initial draft WIP: KEP-3935: initial draft Apr 3, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 3, 2023
@k8s-ci-robot k8s-ci-robot added the sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. label Apr 3, 2023
@liggitt liggitt mentioned this pull request Apr 3, 2023
Closed
8 tasks
@liggitt liggitt force-pushed the kep-3935 branch 7 times, most recently from 313e86a to db7fed8 Compare April 7, 2023 16:43
@shaneutt
Copy link
Member

shaneutt commented May 1, 2023

/cc

@k8s-ci-robot k8s-ci-robot requested a review from shaneutt May 1, 2023 12:06
@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2023
@ahg-g
Copy link
Member

ahg-g commented May 3, 2023

/lgtm

from sig-scheduling

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2023
@neolit123
Copy link
Member

sig-cluster-lifecycle (kubeadm use for skew job)

/approve

@nckturner
Copy link
Contributor

From a cloud provider perspective, the CCM needs to be compatible with node annotations like alpha.kubernetes.io/provided-node-ip (e.g. kubernetes/kubernetes#109794, kubernetes/kubernetes#112184).

Overall this seems like a good idea.
/lgtm from sig-cloud-provider
FYI @andrewsykim @cheftako @elmiko @bridgetkromhout

@deads2k
Copy link
Contributor

deads2k commented May 3, 2023

Thanks for the list of all features. looks like 1.28 got lucky :)

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, deads2k, dims, liggitt, neolit123, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2023
@liggitt
Copy link
Member Author

liggitt commented May 3, 2023

From a cloud provider perspective, the CCM needs to be compatible with node annotations like alpha.kubernetes.io/provided-node-ip (e.g. kubernetes/kubernetes#109794, kubernetes/kubernetes#112184).

That's a good call-out, I added that KEP as needing an update with an explicit timeline for the "The cloud provider will only look at the new annotation." item that accommodates n-3 nodes

@marosset
Copy link
Contributor

marosset commented May 3, 2023

LGTM for sig-windows

@marosset
Copy link
Contributor

marosset commented May 3, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2023
@liggitt
Copy link
Member Author

liggitt commented May 3, 2023

Thanks for all the reviews and feedback. I think the open questions are resolved and work for this KEP and related work is captured in the document. I'll leave this for a day or so in case anyone has follow-up questions/comments, and plan to drop the hold Friday.

@dims
Copy link
Member

dims commented May 3, 2023

drop the hold Friday

+100

@vinaykul
Copy link
Member

vinaykul commented May 4, 2023

/lgtm

@jsafrane
Copy link
Member

jsafrane commented May 4, 2023

lgtm from storage POV.

This was referenced May 5, 2023
Closed
Open
@liggitt
Copy link
Member Author

liggitt commented May 5, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit da806c8 into kubernetes:master May 5, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 5, 2023
@vincepri vincepri mentioned this pull request May 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g ahg-g left review comments

@marosset marosset marosset left review comments

@bryantbiggs bryantbiggs bryantbiggs left review comments

@wojtek-t wojtek-t wojtek-t left review comments

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev left review comments

@sbueringer sbueringer sbueringer left review comments

@robscott robscott robscott left review comments

@danwinship danwinship danwinship left review comments

@dims dims dims left review comments

@vincepri vincepri vincepri approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@shaneutt shaneutt Awaiting requested review from shaneutt

Assignees

@dims dims

@danwinship danwinship

@neolit123 neolit123

@soltysh soltysh

@nckturner nckturner

@jsafrane jsafrane

@dchen1107 dchen1107

@deads2k deads2k

@marosset marosset

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.