-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement E2E test for streamlined upgrades #8615
Comments
/triage accepted |
@fabriziopandini: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What do we mean by "streamlined", as in just go through each revision programmatically? |
"streamlined" was a term used in some discussions, but I'm not sure it is the best one or the most correct one. What we want to test is an upgrade sequence that is allowed by K8s skew policies, which allows you to go up by three minors in faster than going through each revision; the trick is to make the control plane go through all the steps, and only after the control plane is at the target version you can make a single upgrade for all the workers skipping the intermediate steps. The example from the proposal is
|
Thinking again to this issue I'm now leaning toward closing it because IMO we should aim at implementing first-class support for skipping worker upgrades (vs stretching the usage of "topology.cluster.x-k8s.io/hold-upgrade-sequence" for a use case it was not designed for) /close |
@fabriziopandini: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What would you like to be added (User Story)?
It will be great to have a signal about streamlined upgrades in CAPI as well (both for legacy and classy clusters)
Detailed Description
This KEP introduced the idea of streamlined upgrades, and, by playing around with K8s version skew policies, making it possible to upgrade by 2 or 3 Kubernetes minor versions by minimizing the worker's machines rollouts.
Anything else you would like to add?
The UX for streamlined upgrades in CAPI is not ideal, it requires manually upgrading through all the minors and applying "topology.cluster.x-k8s.io/hold-upgrade-sequence" to the first MD till the target version is reached, but it should work.
Label(s) to be applied
/kind feature
/area testing
/area conformance
The text was updated successfully, but these errors were encountered: