Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRR Phase 2 #1707

Merged
merged 2 commits into from
May 21, 2020
Merged

PRR Phase 2 #1707

merged 2 commits into from
May 21, 2020

Conversation

johnbelamaric
Copy link
Member

Update the PRR KEP to define Phase 2 of the PRR process.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 21, 2020
@johnbelamaric
Copy link
Member Author

Note for reviewers: I made sure the commits were separated so you can review one commit at a time, it may be easier that way.

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 21, 2020
@johnbelamaric
Copy link
Member Author

/cc @wojtek-t @deads2k @jeremyrickard @palnabarun

@johnbelamaric
Copy link
Member Author

Note 2: verify won't work until #1706 merges

@johnbelamaric johnbelamaric mentioned this pull request Apr 21, 2020
Merged
@justaugustus
Copy link
Member

/retest
/hold for review

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2020
@justaugustus
Copy link
Member

(tests pass now that #1706 has merged.)

@wojtek-t
Copy link
Member

wojtek-t commented May 8, 2020

/lgtm

@justaugustus - anything else you would like to explicitly review?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2020
@johnbelamaric
Copy link
Member Author

/retest

To see if it passes validation or I need the additional, new KEP metadata. I think it's not yet required.

justaugustus
justaugustus requested changes May 18, 2020
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnbelamaric -- Small nits. Can you update the commit messages to reference the PRR KEP? It's not currently clear.

keps/sig-architecture/1194-prod-readiness/README.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2020
@johnbelamaric
Copy link
Member Author

@justaugustus Ok, I accepted your edit then squashed the commits to just the new directory and then the changes.

@justaugustus
Copy link
Member

...and away we go! 🎉
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus
Copy link
Member

Oh, right:
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2020
@k8s-ci-robot k8s-ci-robot merged commit 942f24b into kubernetes:master May 21, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 21, 2020
@lasomethingsomething lasomethingsomething mentioned this pull request Jun 20, 2020
Closed
@johnbelamaric johnbelamaric deleted the prr-phase-2 branch February 2, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t wojtek-t left review comments

@justaugustus justaugustus justaugustus requested changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@dims dims Awaiting requested review from dims

@deads2k deads2k Awaiting requested review from deads2k

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@palnabarun palnabarun Awaiting requested review from palnabarun

Assignees

@justaugustus justaugustus

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
5 participants
@johnbelamaric @justaugustus @wojtek-t @k8s-ci-robot @jeremyrickard