Add support for symlinks and KEP metadata files #1706
Conversation
Signed-off-by: Monis Khan <[email protected]>
Signed-off-by: Monis Khan <[email protected]>
Signed-off-by: Monis Khan <[email protected]>
Signed-off-by: Monis Khan <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
kind/kep
| if err != nil { | ||
| return err | ||
| } | ||
| files = append(files, filepath.Join(dir, filepath.Dir(newLocation), kepMetadata)) |
There was a problem hiding this comment.
Won't this result in running this multiple times on any kep.yaml that has a symlink for it's associated README.md? If we are only checking the metadata, I would think instead we would want to:
- ignore the symlink
- legacy KEP format, we need to check the file
- new KEP format, we need to verify a
kep.yamlexists, and validate that file
There was a problem hiding this comment.
I did this on purpose to make sure that when you create a symlink, you actually split the old file up correctly for the new format. Processing the kep.yaml files multiple times seems okay to me, the whole process takes a few seconds at most.
Presumably at some point we can remove the old symlinks and drop all of this code.
There was a problem hiding this comment.
Yeah, when there is no error it's fine, when there is an error it's slightly annoying but that's not really a big deal.
We're going to be tweaking all of this code as we evolve the KEP management process, so I am OK with this for now.
|
Thanks for this, @enj! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enj, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
CONSOLE-4327: Add new API field to ConsolePlugin CRD for allowing additional CSP sources
@kubernetes/enhancements-admins