Skip Volume Ownership Change

[mattsmithdatera]

Enhancement Description

• NewPermissionChangePolicy string field in PersistentVolumeClaimVolumeSource struct and related conditional volume ownership change behavior
• Primary contact (assignee): @mattsmithdatera @gnufied
• Responsible SIGs: sig-storage
• KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/695-skip-permission-change
• Link to e2e and/or unit tests: TBD
• Reviewer(s): @saad-ali @msau42
• Approver (likely from SIG/area to which enhancement belongs): @liggitt
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y) 1.18
  • Beta release target (x.y) 1.20
  • Stable release target (x.y)

Pull request implementing this change: kubernetes/kubernetes#73232

[mattsmithdatera]

/sig storage
/kind feature
cc @gnufied @saad-ali @msau42

[gnufied]

/sig api-machinery

[kacole2]

Hello @mattsmithdatera , I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet. I also do not see a KEP. All enhancements require one to be included.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

[justaugustus]

/assign @mattsmithdatera @gnufied

[evillgenius75]

Hi @mattsmithdatera I'm a 1.16 Enhancement Shadow. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheetand the correct milestone and tracked label is applied.

As a reminder, every enhancement requires a KEP in an implementable state with Graduation Criteria explaining each alpha/beta/stable stages requirements. I see that the KEP #696 has yet to be merged.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

[kcmartin]

Hello @mattsmithdatera / @gnufied -- 1.17 Enhancement Shadow here! 🙂

I wanted to reach out to see if this enhancement will be graduating to alpha/beta/stable in 1.17?


Please let me know so that this enhancement can be added to 1.17 tracking sheet.

Thank you!

🔔Friendly Reminder

The current release schedule is

• Monday, September 23 - Release Cycle Begins
• Tuesday, October 15, EOD PST - Enhancements Freeze
• Thursday, November 14, EOD PST - Code Freeze
• Tuesday, November 19 - Docs must be completed and reviewed
• Monday, December 9 - Kubernetes 1.17.0 Released

[gnufied]

We are not doing anything for this in 1.17, but this is a problem that we are aiming to solve for 1.18.

[helayoty]

Hey @mattsmithdatera / @gnufied -- 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to alpha in 1.18 or having a major change in its current level?

The current release schedule is:

Tuesday, January 28th EOD PST - Enhancements Freeze
Thursday, March 5th, EOD PST - Code Freeze
Monday, March 16th - Docs must be completed and reviewed
Tuesday, March 24th - Kubernetes 1.18.0 Released

To be included in the release, this enhancement must have a merged KEP in the implementable status. The KEP must also have graduation criteria and a Test Plan defined.

If you would like to include this enhancement, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly.

Thanks!

[gnufied]

We could not make this feature in 1.17 timeline but we are trying to get this done as an alpha feature in 1.18. I have submitted a KEP with updated design #1478 to address some of the issues raised in original design.

[helayoty]

Thanks @gnufied for the update. Kindly include all k/k PRs in the issue so they can be tracked

[helayoty]

/milestone v1.18

[irvifa]

Hello @mattsmithdatera @gnufied I'm one of the v1.18 docs shadows.
Does this enhancement for (or the work planned for v1.18) require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th., it can just be a placeholder PR at this time. Let me know if you have any questions!

[irvifa]

Hello @mattsmithdatera @gnufied I'm one of the v1.18 docs shadows.

Does this enhancement for (or the work planned for v1.18) require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, which is roughly 1 weeks from now. It can just be a placeholder PR at this time. Let me know if you have any questions!

[jeremyrickard]

Hey @gnufied following up, can you please list out k/k PRs for this enhancement? We are getting close to code freeze on 05 March 2020.

Thanks

[gnufied]

@jeremyrickard thanks. The first PR that implements necessary api change is - https://github.com/kubernetes/kubernetes/pull/88488/files

Update: Same PR kubernetes/kubernetes#88488 contains both API change and implementation.

[VineethReddy02]

Hello @gnufied
The docs placeholder PR deadline is tomorrow please raise a placeholder against the dev-1.18 branch. Having a placeholder PR in place will definitely help us in tracking enhancements much better.

Thanks! :)

[irvifa]

Hi @gnufied Following up, is this enhancement need any docs? If it is can you please create a placeholder PR? Since the deadline should be today.. Thanks!

[gnufied]

it does need docs PR and placeholder PR is - kubernetes/website#19391

[msau42]

/remove-lifecycle rotten

[xing-yang]

/milestone v1.23

[supriya-premkumar]

Hi @gnufied @mattsmithdatera 👋🏽 1.23 Enhancements shadow here. Just checking in as we are getting closer to the enhancements freeze deadline at 11:59 pm PST on Thursday 09/09.

Looks like we are all set for the enhancements freeze 🎉

[ramrodo]

Hi @gnufied @mattsmithdatera 👋🏼 1.23 Docs Shadow here.

This enhancement is marked as Needs Docs for the 1.23 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

[supriya-premkumar]

Hi @gnufied @mattsmithdatera 👋🏽 1.23 Enhancements shadow here.
I wanted to check in on the PR status for this issue since we are approaching code freeze deadline on Tuesday, November 16 at 6:00 pm PST

I see that the PR kubernetes/kubernetes#73232 is closed.

For this issue to be included in the release please make sure to

1. Link the updated PRs in the description
2. Merge the PRs(k/k) before code freeze deadline

Marking this issue as atRisk on the tracking sheet for now. Please let me know once you have updated it.

[xing-yang]

Hi @supriya-premkumar,

The following PR is for this enhancement issue and it is already merged:
kubernetes/kubernetes#105885

[gnufied]

I am working on docs PR for this feature. Please stay tuned, I will update this thread.

[gnufied]

Docs PR - kubernetes/website#30553

[dimm0]

Hi all,
Glad it's moving to GA, but I still can't make fsGroupChangePolicy: "OnRootMismatch" to work... The files in a volume are always chowned to the fsGroup. I'm using the ceph CSI drivers by rook.

[gnufied]

I think there is a bug in ceph-csi driver where it explicitly chmods volume path on nodestage which results in dropping setgid bit expected by kubelet - ceph/ceph-csi#2697

Once that is fixed IIRC it works as expected. cc @humblec @Madhu-1

[humblec]

I think there is a bug in ceph-csi driver where it explicitly chmods volume path on nodestage which results in dropping setgid bit expected by kubelet - ceph/ceph-csi#2697

Once that is fixed IIRC it works as expected. cc @humblec @Madhu-1

Correct @gnufied , I am in path of fixing it.. Initial testing was done with the change in place and it is working as expected. will be revisiting the fix PR soon.

[gracenng]

Hi @gnufied @mattsmithdatera ,

1.24 Enhancements Lead here. Could you please update this enhancements's KEP status to implemented, then close this issue?

Thanks :)

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.