rbd: dont attempt explicit permission mod change from the RBD driver #2697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏 |
This was referenced Jan 6, 2022
humblec
force-pushed
the
fsgroup
branch
2 times, most recently
from
dc9f43c
to
6092601
Compare
humblec
changed the title
humblec
requested review from
nixpanic,
Madhu-1 and
a team
and removed request for
nixpanic
|
/retest ci/centos/mini-e2e-helm/k8s-1.21 |
|
@ceph/ceph-csi-contributors requesting review as this is important one to be fixed. |
|
Cc @ceph/ceph-csi-maintainers ptal . |
Madhu-1
approved these changes
Jan 25, 2022
|
@humblec please update the PR description. |
Madhu-1
approved these changes
Jan 25, 2022
yati1998
approved these changes
Jan 25, 2022
currently we are overriding the permission to `0o777` at time of node stage which is not the correct action. That said, this permission change causes an extra permission correction at time of nodestaging by the CO while the FSGROUP change policy has been set to `OnRootMismatch`. Signed-off-by: Humble Chirammal <[email protected]>
considering the pod has run as normal user, the fsgroup has also set to the same. Signed-off-by: Humble Chirammal <[email protected]>
|
/retest ci/centos/k8s-e2e-external-storage/1.23 |
|
/retest ci/centos/k8s-e2e-external-storage/1.23 |
|
@Mergifyio rebase |
☑️ Nothing to do
|
|
@Mergifyio refresh |
✅ Pull request refreshed |
|
/retest ci/centos/k8s-e2e-external-storage/1.23 |
|
@Mergifyio refresh |
✅ Pull request refreshed |
akalenyu
added a commit
to akalenyu/kubevirt
that referenced
this pull request
Nov 9, 2022
As non-root out of the box, most storage's won't give us a PVC that is world writeable. Noticed this on OpenShift testing lanes where cephcsi is used instead of the "local" SC that is used in kubevirtci. Ceph stopping chmod 777 reference: ceph/ceph-csi#2697 Signed-off-by: Alex Kalenyuk <[email protected]>
akalenyu
added a commit
to akalenyu/kubevirt
that referenced
this pull request
Nov 9, 2022
As non-root out of the box, most storage's won't give us a PVC that is world writeable. Noticed this on OpenShift testing lanes where cephcsi is used instead of the "local" SC that is used in kubevirtci. Ceph stopping chmod 777 reference: ceph/ceph-csi#2697 Signed-off-by: Alex Kalenyuk <[email protected]>
akalenyu
added a commit
to akalenyu/kubevirt
that referenced
this pull request
Nov 9, 2022
As non-root out of the box, most storage's won't give us a PVC that is world writeable. Noticed this on OpenShift testing lanes where cephcsi is used instead of the "local" SC that is used in kubevirtci. Ceph stopping chmod 777 reference: ceph/ceph-csi#2697 Signed-off-by: Alex Kalenyuk <[email protected]>
akalenyu
added a commit
to akalenyu/kubevirt
that referenced
this pull request
Nov 13, 2022
As non-root out of the box, most storage's won't give us a PVC that is world writeable. Noticed this on OpenShift testing lanes where cephcsi is used instead of the "local" SC that is used in kubevirtci. Ceph stopping chmod 777 reference: ceph/ceph-csi#2697 Signed-off-by: Alex Kalenyuk <[email protected]>
akalenyu
added a commit
to akalenyu/kubevirt
that referenced
this pull request
Nov 14, 2022
As non-root out of the box, most storage's won't give us a PVC that is world writeable. Noticed this on OpenShift testing lanes where cephcsi is used instead of the "local" SC that is used in kubevirtci. Ceph stopping chmod 777 reference: ceph/ceph-csi#2697 Signed-off-by: Alex Kalenyuk <[email protected]>
kubevirt-bot
pushed a commit
to kubevirt-bot/kubevirt
that referenced
this pull request
Nov 15, 2022
As non-root out of the box, most storage's won't give us a PVC that is world writeable. Noticed this on OpenShift testing lanes where cephcsi is used instead of the "local" SC that is used in kubevirtci. Ceph stopping chmod 777 reference: ceph/ceph-csi#2697 Signed-off-by: Alex Kalenyuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently we are overriding the permission to
0o777at time of nodestage which is not the correct action. That said, this permission
change causes an extra permission correction at time of nodestaging
by the CO while the FSGROUP change policy has been set to
OnRootMismatch.Signed-off-by: Humble Chirammal [email protected]