Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #2696 #2969

Merged
merged 4 commits into from
Nov 27, 2018
Merged

Fix for #2696 #2969

merged 4 commits into from
Nov 27, 2018

Conversation

ramnar
Copy link
Contributor

@ramnar ramnar commented Nov 25, 2018

FILE: ./keps/sig-cluster-lifecycle/0003-cluster-api.md
[✖] https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/apis/kubeadm/v1alpha1/types.go
→ Status: 404

FILE: ./keps/sig-auth/0014-dynamic-audit-configuration.md
[✖] http://github.com/kubernetes/community/blob/master/Users/patrick/go/src/k8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/authorization/authorizer/interfaces.go
→ Status: 404

FILE: ./sig-apps/agenda.md
[✖] www.github.com/kubernetes/helm → Status: 400 Error: ENOENT: no such
file or directory, access
'/home/jorge/src/kubernetes/community/sig-apps/www.github.com/kubernetes/helm'
[✖] https://deis.com/ → Status: 0 Error: ETIMEDOUT

FILE: ./sig-cli/migrated-from-wiki/roadmap-kubectl.md
[✖] http://kubernetes.sh/kploy/ → Status: 404

@ramnar
Fix for 2696
e95c60a 
FILE: ./keps/sig-cluster-lifecycle/0003-cluster-api.md
[✖] https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/apis/kubeadm/v1alpha1/types.go
→ Status: 404

FILE: ./keps/sig-auth/0014-dynamic-audit-configuration.md
[✖] http://github.com/kubernetes/community/blob/master/Users/patrick/go/src/k8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/authorization/authorizer/interfaces.go
→ Status: 404

FILE: ./sig-apps/agenda.md
[✖] www.github.com/kubernetes/helm → Status: 400 Error: ENOENT: no such
file or directory, access
'/home/jorge/src/kubernetes/community/sig-apps/www.github.com/kubernetes/helm'
[✖] https://deis.com/ → Status: 0 Error: ETIMEDOUT

FILE: ./sig-cli/migrated-from-wiki/roadmap-kubectl.md
[✖] http://kubernetes.sh/kploy/ → Status: 404
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Nov 25, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @ramnar. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/pm labels Nov 25, 2018
@idealhack
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 26, 2018
nikhita
nikhita reviewed Nov 26, 2018
View reviewed changes
sig-apps/agenda.md Outdated
@@ -4,7 +4,7 @@ _Note, the [minutes and agenda have moved to Google Docs](https://docs.google.co

## August 17, 2016
* Intro / Agenda
* Brian Hardock of the Deis Helm team will demo [Helm](www.github.com/kubernetes/helm).
* Brian Hardock of the Deis Helm team will demo [Helm](https://github.com/kubernetes/helm).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Helm moved to its own org, the kubernetes/helm link redirects to the helm/helm repo. Would be good to update this link directly to https://github.com/helm/helm.

nikhita
nikhita reviewed Nov 26, 2018
View reviewed changes
sig-apps/agenda.md Outdated
@@ -22,7 +22,7 @@ _Note, the [minutes and agenda have moved to Google Docs](https://docs.google.co

## July 27, 2016 [[notes](minutes/2016-07-27.md)]
* Intro
* [Gerred Dillon](https://twitter.com/justicefries) will do a demo of [Deis](https://deis.com/)
* [Gerred Dillon](https://twitter.com/justicefries) will do a demo of [Deis](https://azure.microsoft.com/en-us/services/kubernetes-service/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better to use this link here: https://github.com/deis.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the Deis link is moot because of the Microsoft acquisition. Deis is no more... 😢

@nikhita
Copy link
Member

nikhita commented Nov 26, 2018

I don't think we even need https://github.com/kubernetes/community/blob/master/sig-apps/agenda.md.

But deciding if we need this or not, and if not archiving the contents of that file and removing it, is out of scope for this PR.

@ramnar
Review Comments incorporated for 2969
66407a6 
FILE: ./sig-apps/agenda.md
[✖] www.github.com/kubernetes/helm → Status: 400 Error: ENOENT: no such
file or directory, access
'/home/jorge/src/kubernetes/community/sig-apps/www.github.com/kubernetes/helm'
[✖] https://deis.com/ → Status: 0 Error: ETIMEDOUT
@ramnar
Copy link
Contributor Author

ramnar commented Nov 26, 2018

@nikhita - I have implemented your review comments

@nikhita
Copy link
Member

nikhita commented Nov 26, 2018

@ramnar Looks good! Can you squash the commits into a single commit?

@ramnar
Fix for 2696
5463456 
FILE: ./keps/sig-cluster-lifecycle/0003-cluster-api.md
[✖] https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/apis/kubeadm/v1alpha1/types.go
→ Status: 404

FILE: ./keps/sig-auth/0014-dynamic-audit-configuration.md
[✖] http://github.com/kubernetes/community/blob/master/Users/patrick/go/src/k8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/authorization/authorizer/interfaces.go
→ Status: 404

FILE: ./sig-apps/agenda.md
[✖] www.github.com/kubernetes/helm → Status: 400 Error: ENOENT: no such
file or directory, access
'/home/jorge/src/kubernetes/community/sig-apps/www.github.com/kubernetes/helm'
[✖] https://deis.com/ → Status: 0 Error: ETIMEDOUT

FILE: ./sig-cli/migrated-from-wiki/roadmap-kubectl.md
[✖] http://kubernetes.sh/kploy/ → Status: 404

Review Comments incorporated for 2969

FILE: ./sig-apps/agenda.md
[✖] www.github.com/kubernetes/helm → Status: 400 Error: ENOENT: no such
file or directory, access
'/home/jorge/src/kubernetes/community/sig-apps/www.github.com/kubernetes/helm'
[✖] https://deis.com/ → Status: 0 Error: ETIMEDOUT
@ramnar
Merge branch 'brokenlinks_fix' of https://github.com/ramnar/community…
362fe12 
….git into brokenlinks_fix
@nikhita
Copy link
Member

nikhita commented Nov 26, 2018

/lgtm

/assign @cblecker
for approval + adding the squash label

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2018
@cblecker cblecker added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 27, 2018
@cblecker
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2018
@k8s-ci-robot k8s-ci-robot merged commit c701c75 into kubernetes:master Nov 27, 2018
justaugustus pushed a commit to justaugustus/community that referenced this pull request Dec 1, 2018
@ramnar @k8s-ci-robot
Fix for kubernetes#2696 (kubernetes#2969)
fe6c0cc 
* Fix for 2696

FILE: ./keps/sig-cluster-lifecycle/0003-cluster-api.md
[✖] https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/apis/kubeadm/v1alpha1/types.go
→ Status: 404

FILE: ./keps/sig-auth/0014-dynamic-audit-configuration.md
[✖] http://github.com/kubernetes/community/blob/master/Users/patrick/go/src/k8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/authorization/authorizer/interfaces.go
→ Status: 404

FILE: ./sig-apps/agenda.md
[✖] www.github.com/kubernetes/helm → Status: 400 Error: ENOENT: no such
file or directory, access
'/home/jorge/src/kubernetes/community/sig-apps/www.github.com/kubernetes/helm'
[✖] https://deis.com/ → Status: 0 Error: ETIMEDOUT

FILE: ./sig-cli/migrated-from-wiki/roadmap-kubectl.md
[✖] http://kubernetes.sh/kploy/ → Status: 404

* Review Comments incorporated for 2969

FILE: ./sig-apps/agenda.md
[✖] www.github.com/kubernetes/helm → Status: 400 Error: ENOENT: no such
file or directory, access
'/home/jorge/src/kubernetes/community/sig-apps/www.github.com/kubernetes/helm'
[✖] https://deis.com/ → Status: 0 Error: ETIMEDOUT

* Fix for 2696

FILE: ./keps/sig-cluster-lifecycle/0003-cluster-api.md
[✖] https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/apis/kubeadm/v1alpha1/types.go
→ Status: 404

FILE: ./keps/sig-auth/0014-dynamic-audit-configuration.md
[✖] http://github.com/kubernetes/community/blob/master/Users/patrick/go/src/k8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/authorization/authorizer/interfaces.go
→ Status: 404

FILE: ./sig-apps/agenda.md
[✖] www.github.com/kubernetes/helm → Status: 400 Error: ENOENT: no such
file or directory, access
'/home/jorge/src/kubernetes/community/sig-apps/www.github.com/kubernetes/helm'
[✖] https://deis.com/ → Status: 0 Error: ETIMEDOUT

FILE: ./sig-cli/migrated-from-wiki/roadmap-kubectl.md
[✖] http://kubernetes.sh/kploy/ → Status: 404

Review Comments incorporated for 2969

FILE: ./sig-apps/agenda.md
[✖] www.github.com/kubernetes/helm → Status: 400 Error: ENOENT: no such
file or directory, access
'/home/jorge/src/kubernetes/community/sig-apps/www.github.com/kubernetes/helm'
[✖] https://deis.com/ → Status: 0 Error: ETIMEDOUT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhita nikhita nikhita left review comments

@jdumars jdumars jdumars left review comments

@enj enj Awaiting requested review from enj

@prydonius prydonius Awaiting requested review from prydonius

Assignees

@cblecker cblecker

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ramnar @k8s-ci-robot @idealhack @nikhita @cblecker @jdumars