Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
* Fix for 2696

FILE: ./keps/sig-cluster-lifecycle/0003-cluster-api.md
[✖] https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/apis/kubeadm/v1alpha1/types.go
→ Status: 404

FILE: ./keps/sig-auth/0014-dynamic-audit-configuration.md
[✖] http://github.com/kubernetes/community/blob/master/Users/patrick/go/src/k8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/authorization/authorizer/interfaces.go
→ Status: 404

FILE: ./sig-apps/agenda.md
[✖] www.github.com/kubernetes/helm → Status: 400 Error: ENOENT: no such
file or directory, access
'/home/jorge/src/kubernetes/community/sig-apps/www.github.com/kubernetes/helm'
[✖] https://deis.com/ → Status: 0 Error: ETIMEDOUT

FILE: ./sig-cli/migrated-from-wiki/roadmap-kubectl.md
[✖] http://kubernetes.sh/kploy/ → Status: 404

* Review Comments incorporated for 2969

FILE: ./sig-apps/agenda.md
[✖] www.github.com/kubernetes/helm → Status: 400 Error: ENOENT: no such
file or directory, access
'/home/jorge/src/kubernetes/community/sig-apps/www.github.com/kubernetes/helm'
[✖] https://deis.com/ → Status: 0 Error: ETIMEDOUT

* Fix for 2696

FILE: ./keps/sig-cluster-lifecycle/0003-cluster-api.md
[✖] https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/apis/kubeadm/v1alpha1/types.go
→ Status: 404

FILE: ./keps/sig-auth/0014-dynamic-audit-configuration.md
[✖] http://github.com/kubernetes/community/blob/master/Users/patrick/go/src/k8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/authorization/authorizer/interfaces.go
→ Status: 404

FILE: ./sig-apps/agenda.md
[✖] www.github.com/kubernetes/helm → Status: 400 Error: ENOENT: no such
file or directory, access
'/home/jorge/src/kubernetes/community/sig-apps/www.github.com/kubernetes/helm'
[✖] https://deis.com/ → Status: 0 Error: ETIMEDOUT

FILE: ./sig-cli/migrated-from-wiki/roadmap-kubectl.md
[✖] http://kubernetes.sh/kploy/ → Status: 404

Review Comments incorporated for 2969

FILE: ./sig-apps/agenda.md
[✖] www.github.com/kubernetes/helm → Status: 400 Error: ENOENT: no such
file or directory, access
'/home/jorge/src/kubernetes/community/sig-apps/www.github.com/kubernetes/helm'
[✖] https://deis.com/ → Status: 0 Error: ETIMEDOUT
  • Loading branch information
ramnar authored and k8s-ci-robot committed Nov 27, 2018
1 parent 5d29ac2 commit fe6c0cc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion sig-auth/0014-dynamic-audit-configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ parameters. It will then utilize the `LevelAndStages` method in the policy
and drop any unneeded sections. The new dynamic backend will implement the `EnforcedSink` interface, and update its state
based on a shared informer. For the existing backends to comply, a method will be added that implements the `EnforcedSink` interface.

Implementing the [attribute interface](/Users/patrick/go/src/k8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/authorization/authorizer/interfaces.go)
Implementing the [attribute interface](https://github.com/kubernetes/kubernetes/tree/master/staging/src/k8s.io/apiserver/pkg/authorization/authorizer/interfaces.go)
based on the Event struct was also explored. This would allow us to keep the existing `Sink` interfaces, however it would
require parsing the request URI twice in the pipeline due to how that field is represented in the Event. This was determined
to not be worth the cost.
Expand Down
2 changes: 1 addition & 1 deletion sig-cluster-lifecycle/0003-cluster-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ These use cases are out of scope entirely:

This level of the Cluster Management API describes the global configuration of a cluster. It should be capable of representing the versioning and configuration of the entire control plane, irrespective of the representation of nodes.

Given the recent efforts of SIG Cluster Lifecycle to make kubeadm the de facto standard toolkit for cloud- and vendor-agnostic cluster initialization, and because kubeadm has [an existing API](https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/apis/kubeadm/v1alpha1/types.go) to define the global configuration for a cluster, it makes sense to coalesce the global portion of the Cluster API with the API used by “kubeadm init” to configure a cluster master.
Given the recent efforts of SIG Cluster Lifecycle to make kubeadm the de facto standard toolkit for cloud- and vendor-agnostic cluster initialization, and because kubeadm has [an existing API](https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/apis/kubeadm/v1alpha3/types.go) to define the global configuration for a cluster, it makes sense to coalesce the global portion of the Cluster API with the API used by “kubeadm init” to configure a cluster master.

A current goal is to make these APIs as cloud-agnostic as possible, so that the entire definition of a Cluster could remain reasonably in-sync across different deployments potentially in different cloud providers, which would help enable hybrid usecases where it’s desirable to have key configuration stay in sync across different clusters potentially in different clouds/environments. However, this goal is balanced against making the APIs coherent and usable, which strict separation may harm.

Expand Down

0 comments on commit fe6c0cc

Please sign in to comment.