Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Establish GitHub Management Subproject #2388

Merged
merged 1 commit into from
Jul 23, 2018
Merged

Establish GitHub Management Subproject #2388

merged 1 commit into from
Jul 23, 2018

Conversation

cblecker
Copy link
Member

This creates the subproject proposed in #2367.

Fixes #2367.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 18, 2018
@cblecker
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Jul 18, 2018
@cblecker
Copy link
Member Author

/area github-management

@k8s-ci-robot k8s-ci-robot added the area/github-management Issues or PRs related to GitHub Management subproject label Jul 18, 2018
@spiffxp
Copy link
Member

spiffxp commented Jul 19, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2018
@cblecker
Copy link
Member Author

/hold cancel
/assign @grodrigues3

We achieved consensus on this last week. Ready for merge!

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2018
@spiffxp
Copy link
Member

spiffxp commented Jul 23, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2018
@k8s-ci-robot k8s-ci-robot merged commit 3938ea9 into kubernetes:master Jul 23, 2018
@cblecker cblecker deleted the github-subproj branch July 23, 2018 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdumars jdumars Awaiting requested review from jdumars

@parispittman parispittman Awaiting requested review from parispittman

Assignees

@spiffxp spiffxp

@grodrigues3 grodrigues3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cblecker @spiffxp @k8s-ci-robot @grodrigues3