Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: GitHub Management Subproject in Contributor Experience #2367

Closed
cblecker opened this issue Jul 11, 2018 · 9 comments
Closed

Proposal: GitHub Management Subproject in Contributor Experience #2367

cblecker opened this issue Jul 11, 2018 · 9 comments
Assignees
Labels
area/github-management Issues or PRs related to GitHub Management subproject sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.

Comments

@cblecker
Copy link
Member

cblecker commented Jul 11, 2018

History:

The Kubernetes project uses Github extensively to store and organize code, manage issues and documentation, and provide a consistent contributor flow.

With the size and growth of the Kubernetes project, management of our Github footprint has historically been a challenge. Management and permissions are handled in an ad-hoc way.

Proposal:

I'd like to propose a subproject under Contributor Experience to handle and manage GitHub settings, permissions, security, and process.

This subproject will be responsible for:

  • Establishing policies, standards, and procedures for routine GitHub management tasks, including but not limited to: org membership, org permissions, repo creation/administration
  • Establishing a policy around "Org Owner" permissions, and grant/limit these privileges accordingly
  • Establishing policies and best practices for bot accounts, service accounts, webooks, and third-party integrations
  • Maintaining documentation related to the above
  • Establishing a "GitHub Administration team" that will oversee the execution of GitHub management tasks (inviting new members to the org, creating repos, executing moderation decisions, auditing permissions)
  • Working with other sigs and interested parties in the project to execute GitHub tasks where required

This subproject will explicitly not be responsible for:

  • Tooling and automation for GitHub (this falls under sig-testing, and the sig-contributor-experience Contributor Workflow and Automation subproject)
  • Determining policies around which repos can get created (this falls under sig-architecture and the steering committee)
  • Moderation policies and escalations on GitHub (this falls under the Moderation subproject, the Code of Conduct committee, and the steering committee)
  • Contributor workflow within Kubernetes repos, e.g. mandated use of labels (this falls under the guise of the subproject responsible for the repo, and the Contributor Workflow and Automation subproject)
@cblecker cblecker added the sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. label Jul 11, 2018
@cblecker cblecker self-assigned this Jul 11, 2018
@philips
Copy link
Contributor

philips commented Jul 13, 2018

Make sense to me.

@spiffxp
Copy link
Member

spiffxp commented Jul 16, 2018

Good list and anti-list. Many of these seems like human bandaids for the lack of docs or automation, so part of me wonders if this couldn't be disbanded / merged away once these gaps are filled. But let's get there first and then ponder that.

@spiffxp
Copy link
Member

spiffxp commented Jul 16, 2018

@bgrant0607
Copy link
Member

+1

Github changes available settings on a not-infrequent basis, and sometimes owners are notified and sometimes not. Having someone with the experience and bandwidth to stay on top of them would be valuable.

Additionally, some repo owners want to enable a variety of applications, but not all applications are well behaved. For example, some third-party applications ask for permission from users to do arbitrary github actions as them across all orgs to which they have access. I think we need both a whitelist of applications and a general policy about what's acceptable.

@bgrant0607
Copy link
Member

One more detail: Much as with the security team, there needs to be a private channel to report potential security issues with our github orgs and repos, so they can be investigated and potentially acted upon prior to public disclosure.

@bgrant0607
Copy link
Member

Re. automation: I don't think this role can ever go away. Among other issues, not all of github's admin features are accessible via APIs, someone needs to respond to requests from contributors, someone needs to evaluate notifications from github about changes, someone needs to monitor https://blog.github.com/changelog/, and so on.

@cblecker
Copy link
Member Author

/area github-management

@k8s-ci-robot k8s-ci-robot added the area/github-management Issues or PRs related to GitHub Management subproject label Jul 18, 2018
@cblecker
Copy link
Member Author

On the security point: We'll be establishing a team that holds the owner powers to do things in GitHub, but I think for the reporting channel, I would suggest that go the kubernetes.io/security PST we already have. I would submit that they are in the best place to triage any incoming security reports, figure out which pieces of the project they concern, and then escalate to the appropriate team (if GitHub related, then it would be the team we are creating).

I'm open though to reasons for or against this.

(cc: @philips @jessfraz @cjcullen @tallclair @liggitt)

@philips
Copy link
Contributor

philips commented Jul 18, 2018

I think just using the [email protected] reporting works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github-management Issues or PRs related to GitHub Management subproject sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.
Projects
None yet
Development

No branches or pull requests

5 participants