Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"create-update-delete-deployment" example outdated #346

Closed
rabenhorst opened this issue Dec 18, 2017 · 12 comments
Closed

"create-update-delete-deployment" example outdated #346

rabenhorst opened this issue Dec 18, 2017 · 12 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@rabenhorst
Copy link

rabenhorst commented Dec 18, 2017 •
edited
Loading

The "create-update-delete-deployment" example seems to be outdated because
RollbackTo of v1beta1.DeploymentSpec is deprecated.

There example should be updated using Rollback of v1beta1.DeploymentExpansion.
@nulltrope
Copy link
Contributor

@mactr0n good catch. I'll get that updated

@anubhakushwaha
Copy link
Contributor

@sttts @jekohk I would like to work on this issue

@nulltrope
Copy link
Contributor

@anubhakushwaha feel free to pick this up. Let me know if you have any questions but it should be pretty straightforward.

@nikhita
Copy link
Member

nikhita commented Feb 7, 2018

apps/v1 deployments are GA so the example should be updated to it.

@nikhita
Copy link
Member

nikhita commented Feb 7, 2018 •
edited
Loading

@anubhakushwaha You can use kubernetes/kubernetes#58446 as a reference.

https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.9/#deployment-v1-apps

@nikhita
Copy link
Member

nikhita commented Feb 7, 2018

/help

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Feb 7, 2018
@nikhita
Copy link
Member

nikhita commented Feb 7, 2018

oops

/remove-help

since already assigned to @anubhakushwaha

@k8s-ci-robot k8s-ci-robot removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Feb 7, 2018
@nikhita
Copy link
Member

nikhita commented Feb 7, 2018

@anubhakushwaha When deployments are updated to use apps/v1, we should probably end up documenting this as well (see kubernetes/kubernetes#59104).

@nulltrope
Copy link
Contributor

Hi @anubhakushwaha
I believe you need to use the Rollback function from the DeploymentExpansion interface in extensions/v1beta1

This was referenced Feb 9, 2018
Closed
Merged
@nikhita
Copy link
Member

nikhita commented Feb 28, 2018

/assign @k8s-external-contributor

@k8s-ci-robot k8s-ci-robot assigned ghost Feb 28, 2018
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Apr 6, 2018
Merge pull request #59970 from anubhakushwaha/Update_deployment_example
6dfcaab 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Updated the "create-update-delete-deployment" example to use apps/v1 and removed rollback example

**What this PR does / why we need it**:

*Waiting for migration to apps/v1*
> The current example at [create-update-delete-deployment/main.go](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/examples/create-update-delete-deployment/main.go) was using `RollbackTo` of `v1beta1.DeploymentSpec` which is deprecated.

The current implementation upgrades `create-update-delete-deployment` main.go to use **apps/v1** instead of **extensions/v1beta1** and removed rollback example for now. 

**Which issue(s) this PR fixes**
Helps kubernetes/client-go#346

**Special notes for your reviewer**:
Since it's my first PR dealing with codebase and not a typo fix :xD please let me know my mistakes.
I would love to resolve them.

@nikhita @sttts @jekohk Please review. The other PR #59663  got closed accidentally while changing branch.
k8s-publishing-bot added a commit that referenced this issue Apr 6, 2018
@k8s-publishing-bot
Merge pull request #59970 from anubhakushwaha/Update_deployment_example
47c4857 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Updated the "create-update-delete-deployment" example to use apps/v1 and removed rollback example

**What this PR does / why we need it**:

*Waiting for migration to apps/v1*
> The current example at [create-update-delete-deployment/main.go](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/examples/create-update-delete-deployment/main.go) was using `RollbackTo` of `v1beta1.DeploymentSpec` which is deprecated.

The current implementation upgrades `create-update-delete-deployment` main.go to use **apps/v1** instead of **extensions/v1beta1** and removed rollback example for now.

**Which issue(s) this PR fixes**
Helps #346

**Special notes for your reviewer**:
Since it's my first PR dealing with codebase and not a typo fix :xD please let me know my mistakes.
I would love to resolve them.

@nikhita @sttts @jekohk Please review. The other PR #59663  got closed accidentally while changing branch.

Kubernetes-commit: 6dfcaabe849938a475bcacf5c29f43d4e350e751
sttts pushed a commit to sttts/client-go that referenced this issue Apr 9, 2018
@k8s-publishing-bot
Merge pull request #59970 from anubhakushwaha/Update_deployment_example
a146c48 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Updated the "create-update-delete-deployment" example to use apps/v1 and removed rollback example

**What this PR does / why we need it**:

*Waiting for migration to apps/v1*
> The current example at [create-update-delete-deployment/main.go](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/examples/create-update-delete-deployment/main.go) was using `RollbackTo` of `v1beta1.DeploymentSpec` which is deprecated.

The current implementation upgrades `create-update-delete-deployment` main.go to use **apps/v1** instead of **extensions/v1beta1** and removed rollback example for now.

**Which issue(s) this PR fixes**
Helps kubernetes#346

**Special notes for your reviewer**:
Since it's my first PR dealing with codebase and not a typo fix :xD please let me know my mistakes.
I would love to resolve them.

@nikhita @sttts @jekohk Please review. The other PR #59663  got closed accidentally while changing branch.

Kubernetes-commit: 6dfcaabe849938a475bcacf5c29f43d4e350e751
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 29, 2018
@nikhita
Copy link
Member

nikhita commented May 29, 2018

This is already done by @anubhakushwaha in kubernetes/kubernetes#59970 🎉

Closing this issue. If you have comments about the rollback option using client-go, please comment in #398.

/close

@ashwiniramesha ashwiniramesha mentioned this issue Jun 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated the rollback deployment example to use RollBack function anubhakushwaha/kubernetes
6 participants
@rabenhorst @anubhakushwaha @nulltrope @nikhita @k8s-ci-robot @fejta-bot