-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"create-update-delete-deployment" example outdated #346
Comments
@mactr0n good catch. I'll get that updated |
@sttts @jekohk I would like to work on this issue |
@anubhakushwaha feel free to pick this up. Let me know if you have any questions but it should be pretty straightforward. |
|
/help |
oops /remove-help since already assigned to @anubhakushwaha |
@anubhakushwaha When deployments are updated to use |
Hi @anubhakushwaha |
/assign @k8s-external-contributor |
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Updated the "create-update-delete-deployment" example to use apps/v1 and removed rollback example **What this PR does / why we need it**: *Waiting for migration to apps/v1* > The current example at [create-update-delete-deployment/main.go](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/examples/create-update-delete-deployment/main.go) was using `RollbackTo` of `v1beta1.DeploymentSpec` which is deprecated. The current implementation upgrades `create-update-delete-deployment` main.go to use **apps/v1** instead of **extensions/v1beta1** and removed rollback example for now. **Which issue(s) this PR fixes** Helps kubernetes/client-go#346 **Special notes for your reviewer**: Since it's my first PR dealing with codebase and not a typo fix :xD please let me know my mistakes. I would love to resolve them. @nikhita @sttts @jekohk Please review. The other PR #59663 got closed accidentally while changing branch.
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Updated the "create-update-delete-deployment" example to use apps/v1 and removed rollback example **What this PR does / why we need it**: *Waiting for migration to apps/v1* > The current example at [create-update-delete-deployment/main.go](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/examples/create-update-delete-deployment/main.go) was using `RollbackTo` of `v1beta1.DeploymentSpec` which is deprecated. The current implementation upgrades `create-update-delete-deployment` main.go to use **apps/v1** instead of **extensions/v1beta1** and removed rollback example for now. **Which issue(s) this PR fixes** Helps #346 **Special notes for your reviewer**: Since it's my first PR dealing with codebase and not a typo fix :xD please let me know my mistakes. I would love to resolve them. @nikhita @sttts @jekohk Please review. The other PR #59663 got closed accidentally while changing branch. Kubernetes-commit: 6dfcaabe849938a475bcacf5c29f43d4e350e751
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Updated the "create-update-delete-deployment" example to use apps/v1 and removed rollback example **What this PR does / why we need it**: *Waiting for migration to apps/v1* > The current example at [create-update-delete-deployment/main.go](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/examples/create-update-delete-deployment/main.go) was using `RollbackTo` of `v1beta1.DeploymentSpec` which is deprecated. The current implementation upgrades `create-update-delete-deployment` main.go to use **apps/v1** instead of **extensions/v1beta1** and removed rollback example for now. **Which issue(s) this PR fixes** Helps kubernetes#346 **Special notes for your reviewer**: Since it's my first PR dealing with codebase and not a typo fix :xD please let me know my mistakes. I would love to resolve them. @nikhita @sttts @jekohk Please review. The other PR #59663 got closed accidentally while changing branch. Kubernetes-commit: 6dfcaabe849938a475bcacf5c29f43d4e350e751
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
This is already done by @anubhakushwaha in kubernetes/kubernetes#59970 🎉 Closing this issue. If you have comments about the rollback option using client-go, please comment in #398. /close |
The "create-update-delete-deployment" example seems to be outdated because
RollbackTo
ofv1beta1.DeploymentSpec
is deprecated.There example should be updated using
Rollback
ofv1beta1.DeploymentExpansion
.The text was updated successfully, but these errors were encountered: