Add DeploymentRollback resource

[ravilr]

@jimmidyson @iocanel
Can we get this added:
http://kubernetes.io/docs/api-reference/extensions/v1beta1/definitions/#_v1beta1_deploymentrollback

[iocanel]

@ravilr: Yeah I think that we could.

[jimmidyson]

@ravilr Do you know how to use this resource? I can't see any examples for it anywhere. Is this actually a managed resource or an internal representation?

[ravilr]

from http://kubernetes.io/docs/api-reference/extensions/v1beta1/operations/ (there isn't a direct permalink to the actual operation):

create rollback of a DeploymentRollback
POST /apis/extensions/v1beta1/namespaces/{namespace}/deployments/{name}/rollback
with bodyParameter as v1beta1.DeploymentRollback

so, this looks like being used in subresource rollback operation of deployment resource.

For our use case, where we deploy multiple deployment resources for an app, i realized that it is better to keep the source definition of the deployments in version control somewhere, change it there and keep applying/replace() that, even for rollbacks, rather than using this operation.

[jimmidyson]

Agreed. We don't support any subresources at the moment so until we do you've come up with the best solution. I'm going to close this issue & raise another one to discuss subresources in general as we need to support them properly.

[Siva10]

/help wanted
@jimmidyson Hi . I would like to use the API
POST /apis/extensions/v1beta1/namespaces/{namespace}/deployments/{name}/rollback
to rollback a deployment to its previous version in rollout history.
Is there any proposal to support this feature in your roadmap ? Or to achieve this do we have to still do replace() as mentioned by @ravilr ?
Thanks in advance

[Zephery]

+1 anyone can help?

[doyard]

+1

[stale]

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

[stale]

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

[rohanKanojia]

I think we already have support for DeploymentRollback resource

kubernetes-client/kubernetes-tests/src/test/java/io/fabric8/kubernetes/client/mock/DeploymentTest.java

Lines 432 to 447 in cf18605

	public void testRollback() {
	DeploymentRollback deploymentRollback = new DeploymentRollbackBuilder()
	.withName("deployment1")
	.withNewRollbackTo().withRevision(1l).endRollbackTo()
	.withUpdatedAnnotations(Collections.singletonMap("foo", "bar"))
	.build();
	Status status = new StatusBuilder().build();
	KubernetesClient client = server.getClient();
	server.expect()
	.post()
	.withPath("/apis/extensions/v1beta1/namespaces/test/deployments/deployment1/rollback")
	.andReturn(201, status).once();
	client.extensions().deployments().inNamespace("test").withName("deployment1").rollback(deploymentRollback);
	}

[manusa]

BTW, DeploymentRollback is actually deprecated:

• https://github.com/kubernetes/api/blob/master/extensions/v1beta1/types.go#L150
• https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#rolling-back-to-a-previous-revision
• https://github.com/rancher/rancher/blob/0f2accee571048b1102e825581c9685ce0e9ed74/pkg/api/customization/workload/workload.go#L156

[rohanKanojia]

Yeah, I'm aware of this. But it's still there in Kubernetes 1.17. We need to consider this whenever kubernetes folks decide to remove it's support in future releases.

[ashwiniramesha]

rollback is officially removed in apps/v1 version. I'm using Kubernetes 1.18

ref: kubernetes/client-go#398 (comment)
kubernetes/client-go#346

Is there an alternative available in fabric8io to perform deployment rollbacks with the following steps?

1. List all ReplicaSets the Deployment owns
2. Find the ReplicaSet of a specific revision
3. Copy that ReplicaSet's template back to the Deployment's template

Trying the above way of rolling back results in following exception:

io.fabric8.kubernetes.client.KubernetesClientException: Failure executing: POST at: https://10.44.4.126:6443/apis/apps/v1/namespaces/default/deployments/nginx/rollback. Message: the server could not find the requested resource. Received status: Status(apiVersion=v1, code=404, details=StatusDetails(causes=[], group=null, kind=null, name=null, retryAfterSeconds=null, uid=null, additionalProperties={}), kind=Status, message=the server could not find the requested resource, metadata=ListMeta(_continue=null, remainingItemCount=null, resourceVersion=null, selfLink=null, additionalProperties={}), reason=NotFound, status=Failure, additionalProperties={}).