-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DeploymentRollback resource #404
Comments
@ravilr: Yeah I think that we could. |
@ravilr Do you know how to use this resource? I can't see any examples for it anywhere. Is this actually a managed resource or an internal representation? |
from http://kubernetes.io/docs/api-reference/extensions/v1beta1/operations/ (there isn't a direct permalink to the actual operation):
so, this looks like being used in subresource rollback operation of deployment resource. For our use case, where we deploy multiple deployment resources for an app, i realized that it is better to keep the source definition of the deployments in version control somewhere, change it there and keep applying/replace() that, even for rollbacks, rather than using this operation. |
Agreed. We don't support any subresources at the moment so until we do you've come up with the best solution. I'm going to close this issue & raise another one to discuss subresources in general as we need to support them properly. |
/help wanted |
+1 anyone can help? |
+1 |
This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions! |
This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions! |
I think we already have support for Lines 432 to 447 in cf18605
|
Yeah, I'm aware of this. But it's still there in Kubernetes 1.17. We need to consider this whenever kubernetes folks decide to remove it's support in future releases. |
ref: kubernetes/client-go#398 (comment) Is there an alternative available in
Trying the above way of rolling back results in following exception:
|
@jimmidyson @iocanel
Can we get this added:
http://kubernetes.io/docs/api-reference/extensions/v1beta1/definitions/#_v1beta1_deploymentrollback
The text was updated successfully, but these errors were encountered: