-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/apm-server] Elastic APM Server #6058
Conversation
@foxish Thanks for maintaining the charts project! Would you mind reviewing this? |
/assign @foxish |
- name: NODE_NAME | ||
valueFrom: | ||
fieldRef: | ||
fieldPath: spec.nodeName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these 2 variables probably come from an older version, since 6.2
we no longer need them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to hear! Thanks for pointing it out and the enhancement. Just curious, does libbeat get the node name and the namespace by calling K8S API now?
Looking awesome! I think all comments I did in #5766 apply here too |
@exekias Thanks for the review again |
@@ -0,0 +1,92 @@ | |||
apiVersion: apps/v1beta2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could go with apps/v1
since you mention K8s 1.9 as minimum requirement.
@@ -0,0 +1,11 @@ | |||
# apm-server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please improve the readme. You should add a config table.
/assign |
[Elastic APM](https://www.elastic.co/guide/en/apm/get-started/current/overview.html) is an application performance monitoring system built on the Elastic Stack. This chart is to install the server part of the system. See the official documentation to setup the agent part of the system. Even though apm-server is built by the Elastic team, it supports alternative outputs other than Elasticsearch via built-in beat output plugins and community plugins. For example, [awsbeats](https://github.com/s12v/awsbeats) enables apm-server to write collected application traces to AWS Kinesis Streams. Other changelog: - Include the commented-out elasticsearch output too support common use-cases - Include the configuraion table in the README
@unguiculus Thanks for reviewing! I've addressed your comments in the last commit. Would you mind taking a look again? |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mumoshu, unguiculus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[Elastic APM](https://www.elastic.co/guide/en/apm/get-started/current/overview.html) is an application performance monitoring system built on the Elastic Stack. This chart is to install the server part of the system. See the official documentation to setup the agent part of the system. Even though apm-server is built by the Elastic team, it supports alternative outputs other than Elasticsearch via built-in beat output plugins and community plugins. For example, [awsbeats](https://github.com/s12v/awsbeats) enables apm-server to write collected application traces to AWS Kinesis Streams. Other changelog: - Include the commented-out elasticsearch output too support common use-cases - Include the configuraion table in the README
[Elastic APM](https://www.elastic.co/guide/en/apm/get-started/current/overview.html) is an application performance monitoring system built on the Elastic Stack. This chart is to install the server part of the system. See the official documentation to setup the agent part of the system. Even though apm-server is built by the Elastic team, it supports alternative outputs other than Elasticsearch via built-in beat output plugins and community plugins. For example, [awsbeats](https://github.com/s12v/awsbeats) enables apm-server to write collected application traces to AWS Kinesis Streams. Other changelog: - Include the commented-out elasticsearch output too support common use-cases - Include the configuraion table in the README Signed-off-by: voron <[email protected]>
once it's deployed, how should one configure the apm-client to connect to those servers? |
Elastic APM is an application performance monitoring system built on the Elastic Stack. This chart is to install the server part of the system.
See the official documentation to setup the agent part of the system.
Even though apm-server is built by the Elastic team, it supports alternative outputs other than Elasticsearch via built-in beat output plugins and community plugins. For example, awsbeats enables apm-server to write collected application traces to AWS Kinesis Streams.