Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/apm-server] Elastic APM Server #6058

Merged
merged 1 commit into from
Jun 18, 2018
Merged

Conversation

mumoshu
Copy link
Collaborator

@mumoshu mumoshu commented Jun 11, 2018

Elastic APM is an application performance monitoring system built on the Elastic Stack. This chart is to install the server part of the system.

See the official documentation to setup the agent part of the system.

Even though apm-server is built by the Elastic team, it supports alternative outputs other than Elasticsearch via built-in beat output plugins and community plugins. For example, awsbeats enables apm-server to write collected application traces to AWS Kinesis Streams.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 11, 2018
@mumoshu
Copy link
Collaborator Author

mumoshu commented Jun 11, 2018

@foxish Thanks for maintaining the charts project! Would you mind reviewing this?

@mumoshu
Copy link
Collaborator Author

mumoshu commented Jun 11, 2018

/assign @foxish

- name: NODE_NAME
valueFrom:
fieldRef:
fieldPath: spec.nodeName
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these 2 variables probably come from an older version, since 6.2 we no longer need them

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to hear! Thanks for pointing it out and the enhancement. Just curious, does libbeat get the node name and the namespace by calling K8S API now?

@exekias
Copy link

exekias commented Jun 12, 2018

Looking awesome! I think all comments I did in #5766 apply here too

@mumoshu
Copy link
Collaborator Author

mumoshu commented Jun 13, 2018

@exekias Thanks for the review again ☺️ I've addressed the comments in the last two commits.

@@ -0,0 +1,92 @@
apiVersion: apps/v1beta2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could go with apps/v1 since you mention K8s 1.9 as minimum requirement.

@@ -0,0 +1,11 @@
# apm-server
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please improve the readme. You should add a config table.

@unguiculus
Copy link
Member

/assign

[Elastic APM](https://www.elastic.co/guide/en/apm/get-started/current/overview.html) is an application performance monitoring system built on the Elastic Stack. This chart is to install the server part of the system.

See the official documentation to setup the agent part of the system.

Even though apm-server is built by the Elastic team, it supports alternative outputs other than Elasticsearch via built-in beat output plugins and community plugins. For example, [awsbeats](https://github.com/s12v/awsbeats) enables apm-server to write collected application traces to AWS Kinesis Streams.

Other changelog:

- Include the commented-out elasticsearch output too support common use-cases
- Include the configuraion table in the README
@mumoshu
Copy link
Collaborator Author

mumoshu commented Jun 18, 2018

@unguiculus Thanks for reviewing! I've addressed your comments in the last commit. Would you mind taking a look again?

@unguiculus
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 18, 2018
@unguiculus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mumoshu, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2018
@k8s-ci-robot k8s-ci-robot merged commit 71fc612 into helm:master Jun 18, 2018
or1can pushed a commit to or1can/charts that referenced this pull request Jul 10, 2018
[Elastic APM](https://www.elastic.co/guide/en/apm/get-started/current/overview.html) is an application performance monitoring system built on the Elastic Stack. This chart is to install the server part of the system.

See the official documentation to setup the agent part of the system.

Even though apm-server is built by the Elastic team, it supports alternative outputs other than Elasticsearch via built-in beat output plugins and community plugins. For example, [awsbeats](https://github.com/s12v/awsbeats) enables apm-server to write collected application traces to AWS Kinesis Streams.

Other changelog:

- Include the commented-out elasticsearch output too support common use-cases
- Include the configuraion table in the README
voron pushed a commit to dysnix/helm-charts that referenced this pull request Sep 5, 2018
[Elastic APM](https://www.elastic.co/guide/en/apm/get-started/current/overview.html) is an application performance monitoring system built on the Elastic Stack. This chart is to install the server part of the system.

See the official documentation to setup the agent part of the system.

Even though apm-server is built by the Elastic team, it supports alternative outputs other than Elasticsearch via built-in beat output plugins and community plugins. For example, [awsbeats](https://github.com/s12v/awsbeats) enables apm-server to write collected application traces to AWS Kinesis Streams.

Other changelog:

- Include the commented-out elasticsearch output too support common use-cases
- Include the configuraion table in the README

Signed-off-by: voron <[email protected]>
@esseti
Copy link

esseti commented Oct 15, 2018

once it's deployed, how should one configure the apm-client to connect to those servers?
(i've the django app within the same kubernetes cluster, but I can't make it working)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants