-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update azure static sku list #7614
update azure static sku list #7614
Conversation
Hi @rrangith. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@comtalyst can you sanity check this? It's possible the previous PR ran against a non-public Azure cloud? /lgtm |
Running it on my side (public cloud) gives me something nearly the same. We would investigate #7126 later. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: comtalyst, rrangith The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jackfrancis @comtalyst I created some backport PRs for 1.28-1.31 |
@rrangith I don't want to doubt your manual git rebase hygiene! :) But generally it's more deterministic to let the k8s-cherry-pick-bot do this work for us. Let's see if these commands yield successful PR creation outcomes: /cherry-pick cluster-autoscaler-release-1.31 |
@jackfrancis: new pull request created: #7623 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@jackfrancis: new pull request created: #7624 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@jackfrancis: new pull request created: #7625 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@jackfrancis: new pull request created: #7626 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This regenerates the azure static sku list after #7126 removed some instance types. Particularly the
standardLSv2Family
which is still in use. Our cluster autoscaler is currently failing to scaleup in clusters where we use Standard_L8s_V2 for exampleI just ran
gen.go
from westus2 and copied over the resultsSpecial notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: