Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update azure static sku list #7614

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

rrangith
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

This regenerates the azure static sku list after #7126 removed some instance types. Particularly the standardLSv2Family which is still in use. Our cluster autoscaler is currently failing to scaleup in clusters where we use Standard_L8s_V2 for example

I just ran gen.go from westus2 and copied over the results

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Regenerate Azure static SKU list

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 16, 2024
@k8s-ci-robot k8s-ci-robot requested a review from nilo19 December 16, 2024 20:09
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/provider/azure Issues or PRs related to azure provider labels Dec 16, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @rrangith. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 16, 2024
@jackfrancis
Copy link
Contributor

@comtalyst can you sanity check this? It's possible the previous PR ran against a non-public Azure cloud?

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2024
@comtalyst
Copy link
Contributor

Running it on my side (public cloud) gives me something nearly the same. We would investigate #7126 later.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: comtalyst, rrangith

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit da31dff into kubernetes:master Dec 17, 2024
7 checks passed
@rrangith rrangith deleted the update-azure-instance-types branch December 17, 2024 20:19
@rrangith
Copy link
Contributor Author

@jackfrancis @comtalyst I created some backport PRs for 1.28-1.31
#7619
#7620
#7621
#7622

@jackfrancis
Copy link
Contributor

@rrangith I don't want to doubt your manual git rebase hygiene! :) But generally it's more deterministic to let the k8s-cherry-pick-bot do this work for us. Let's see if these commands yield successful PR creation outcomes:

/cherry-pick cluster-autoscaler-release-1.31
/cherry-pick cluster-autoscaler-release-1.30
/cherry-pick cluster-autoscaler-release-1.29
/cherry-pick cluster-autoscaler-release-1.28

@k8s-infra-cherrypick-robot

@jackfrancis: new pull request created: #7623

In response to this:

@rrangith I don't want to doubt your manual git rebase hygiene! :) But generally it's more deterministic to let the k8s-cherry-pick-bot do this work for us. Let's see if these commands yield successful PR creation outcomes:

/cherry-pick cluster-autoscaler-release-1.31
/cherry-pick cluster-autoscaler-release-1.30
/cherry-pick cluster-autoscaler-release-1.29
/cherry-pick cluster-autoscaler-release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@jackfrancis: new pull request created: #7624

In response to this:

@rrangith I don't want to doubt your manual git rebase hygiene! :) But generally it's more deterministic to let the k8s-cherry-pick-bot do this work for us. Let's see if these commands yield successful PR creation outcomes:

/cherry-pick cluster-autoscaler-release-1.31
/cherry-pick cluster-autoscaler-release-1.30
/cherry-pick cluster-autoscaler-release-1.29
/cherry-pick cluster-autoscaler-release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@jackfrancis: new pull request created: #7625

In response to this:

@rrangith I don't want to doubt your manual git rebase hygiene! :) But generally it's more deterministic to let the k8s-cherry-pick-bot do this work for us. Let's see if these commands yield successful PR creation outcomes:

/cherry-pick cluster-autoscaler-release-1.31
/cherry-pick cluster-autoscaler-release-1.30
/cherry-pick cluster-autoscaler-release-1.29
/cherry-pick cluster-autoscaler-release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@jackfrancis: new pull request created: #7626

In response to this:

@rrangith I don't want to doubt your manual git rebase hygiene! :) But generally it's more deterministic to let the k8s-cherry-pick-bot do this work for us. Let's see if these commands yield successful PR creation outcomes:

/cherry-pick cluster-autoscaler-release-1.31
/cherry-pick cluster-autoscaler-release-1.30
/cherry-pick cluster-autoscaler-release-1.29
/cherry-pick cluster-autoscaler-release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants