-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerate azure static sku list (master) #7126
Regenerate azure static sku list (master) #7126
Conversation
Hi @rakechill. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@rakechill would it be reasonable (read: not too much effort) to wrap this entire E2E process in a script (looks like there isn't a scripts/ directory in @nojnhuh @willie-yao if we have cycles to do this we could reference some similar CAPZ or other Azure uptream examples that can be used as prior art for easily handling the az download/login stuff. |
I have a ticket open to look into something similar -- periodically running this, maybe before each release? happy to get some help/brainstorming on where this would be best to run. |
@@ -5024,6 +5517,34 @@ var InstanceTypes = map[string]*InstanceType{ | |||
MemoryMb: 921600, | |||
GPU: 8, | |||
}, | |||
"Standard_ND96is_H100_v5": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block is a bit different from 1.30. Is that expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting... I wonder if more SKUs were added since last week. Let me double check the output of az command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Looks like we're tracking eventual arrival of full automation in the repo so anyone can easily maintain this going forward. Landing these updates ASAP seems like a good idea in the meantime.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, rakechill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Regenerates the static sku list that acts as a fallback mechanism for dynamic listing
Special notes for your reviewer:
I compared against the output for
az vm --list-skus -o json
. The memory updates + deprecated types are accurate.Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: