Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate azure static sku list (master) #7126

Merged

Conversation

rakechill
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Regenerates the static sku list that acts as a fallback mechanism for dynamic listing

Special notes for your reviewer:

I compared against the output for az vm --list-skus -o json. The memory updates + deprecated types are accurate.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 5, 2024
@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler area/provider/azure Issues or PRs related to azure provider labels Aug 5, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @rakechill. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 5, 2024
@jackfrancis
Copy link
Contributor

@rakechill would it be reasonable (read: not too much effort) to wrap this entire E2E process in a script (looks like there isn't a scripts/ directory in cloudprovider/azure so we'd have to add one.

@nojnhuh @willie-yao if we have cycles to do this we could reference some similar CAPZ or other Azure uptream examples that can be used as prior art for easily handling the az download/login stuff.

@rakechill
Copy link
Contributor Author

@rakechill would it be reasonable (read: not too much effort) to wrap this entire E2E process in a script (looks like there isn't a scripts/ directory in cloudprovider/azure so we'd have to add one.

@nojnhuh @willie-yao if we have cycles to do this we could reference some similar CAPZ or other Azure uptream examples that can be used as prior art for easily handling the az download/login stuff.

I have a ticket open to look into something similar -- periodically running this, maybe before each release? happy to get some help/brainstorming on where this would be best to run.

@@ -5024,6 +5517,34 @@ var InstanceTypes = map[string]*InstanceType{
MemoryMb: 921600,
GPU: 8,
},
"Standard_ND96is_H100_v5": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block is a bit different from 1.30. Is that expected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting... I wonder if more SKUs were added since last week. Let me double check the output of az command

Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Looks like we're tracking eventual arrival of full automation in the repo so anyone can easily maintain this going forward. Landing these updates ASAP seems like a good idea in the meantime.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, rakechill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit d2aca8b into kubernetes:master Aug 5, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants