-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(helm): integrate the helm chart #7467
base: master
Are you sure you want to change the base?
chore(helm): integrate the helm chart #7467
Conversation
Hi @pierluigilenoci. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
24a9612
to
82366b9
Compare
@mwielgus @MaciekPytel @gjtempleton, could you please take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@jackfrancis, could you please also approve? |
/assign @gjtempleton |
/assign @aleksandra-malinowska |
PR #7470 has already been opened to add all the CA flags under the FAQ.md parameter table. |
@pierluigilenoci, you can keep the changes for the charts directory, other than that you can drop them as they are covered in the other PR. |
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jackfrancis, pierluigilenoci The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…as chart example Signed-off-by: Pierluigi Lenoci <[email protected]>
4721e28
to
d4820d7
Compare
@Shubham82 done. |
@Shubham82 I'm a little confused about your earlier comment about another PR. #7470 is the issue that this PR addresses. Is there more than one solution for this in flight? |
@jackfrancis, issue #7470 is opened to add the missing flags in the parameter table under FAQ.md but there is already PR #7014 opened for it in which we add new hack script that Auto-generate the supported flags table in FAQ,md. As mentioned in the issue description, this PR focuses on two problems:
As 1st is already covered in #7014, so it will be good if this PR only covers 2nd issue i.e. updating values.yaml file for charts. |
@jackfrancis, can you please follow up? |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Added node-deletion-delay-timeout and node-deletion-batcher-interval to FAQ.md and as chart example.
Which issue(s) this PR fixes:
Fixes #7470
Fixes #2031 (the lack of update on the FAQ of this PR)
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
NONE