Add script to update cluster-autoscaler flags doc

[rainfd]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fxies #6981

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Welcome @rainfd!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @rainfd. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rainfd
Once this PR has been reviewed and has the lgtm label, please assign maciekpytel for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Shubham82]

/ok-to-test

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[Shubham82]

/remove-lifecycle stale

[Shubham82]

@rainfd, curious to know about v, there is no such flag for CA under main.go

[rainfd]

v and vmodule come from klog, Is it necessary to remove it?

[Shubham82]

@rainfd, This table contains parameters(flags) that are supported for CA, so mentioning the Klog flags will create confusion for the users.

[Shubham82]

Is it necessary to remove it?

So it will be good if the Klog flags can be removed from this table.

[rainfd]

Is it necessary to remove it?

So it will be good if the Klog flags can be removed from this table.

@Shubham82 cluster-autoscaler also use klog.V(x).Info() to mark log of different levels, this usage is common in the k8s community, so I don't think it really matters

[vadasambar]

Adding --v flag to cluster-autoscaler binary increases log verbosity and helps in debugging. I don't think the end user cares where it comes from.

[vadasambar]

We should write docs with both technical and non-technical users in mind.

[Shubham82]

Hi @vadasambar, My only concern here is that the parameters mentioned here are for CA (comes with CA) and --v is for log verbosity, not a specific parameter to CA.

The following also mentioned in FAQ before the parameter table:

The following startup parameters are supported for cluster autoscaler

[Shubham82]

If all members are ok with it (mention --v in the CA parameter table) if it somehow helps end users/users then I'm also ok with it.

[Shubham82]

cc @gjtempleton, WDYT?

[Shubham82]

Also vmodule, there is no such flag for CA under main.go

[Shubham82]

I have one concern not all the flags are in the parameter table(Flags table in FAQ) you mentioned in this PR. I also checked the script locally, it generated the table but not all the flags are there which are mentioned in the CA main.go. One of the flags is nodeDeletionDelayTimeout.

Please let me know if I missed something here.

[rainfd]

@Shubham82 Alias node-deletion-delay-timeout is in the definition

nodeDeletionDelayTimeout    = flag.Duration("node-deletion-delay-timeout", 2*time.Minute, "Maximum time CA waits for removing delay-deletion.cluster-autoscaler.kubernetes.io/ annotations before deleting the node.")

[Shubham82]

@Shubham82 Alias node-deletion-delay-timeout is in the definition

nodeDeletionDelayTimeout    = flag.Duration("node-deletion-delay-timeout", 2*time.Minute, "Maximum time CA waits for removing delay-deletion.cluster-autoscaler.kubernetes.io/ annotations before deleting the node.")

Sorry My bad, I forgot to mention the hyphen(-) in the flag name, I have rechecked it locally, and flags are generated from the script.

Thanks!

[voelzmo]

/remove-area vertical-pod-autoscaler

[Shubham82]

/remove-area provider/gce
/remove-area provider/azure

[pierluigilenoci]

Is there any ETA for this PR to be merged?