Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure: use new label to identity GPU Nodes #7235

Merged
merged 1 commit into from
Sep 4, 2024
Merged

azure: use new label to identity GPU Nodes #7235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cluster-autoscaler/cloudprovider/azure/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ k8s.io_cluster-autoscaler_node-template_resources_cpu: 3800m
k8s.io_cluster-autoscaler_node-template_resources_memory: 11Gi
```

> **_NOTE_**: GPU autoscaling on VMSS is informed by the presence of BOTH the `accelerator` AND `kubernetes.azure.com/accelerator` Node labels. A VMSS with GPUs whose Nodes do not have BOTH labels may not be scaled correctly. In a future release of cluster-autoscaler, the `accelerator` label will no longer be used and only the `kubernetes.azure.com/accelerator` label will be required.
> **_NOTE_**: GPU autoscaling on VMSS is informed by the presence of the `kubernetes.azure.com/accelerator` Node label. A VMSS with GPUs whose Nodes do not have the label may not be scaled correctly. The `accelerator` label was used for this purpose in versions 1.31 and older.

#### Autoscaling options

Expand Down
2 changes: 1 addition & 1 deletion cluster-autoscaler/cloudprovider/azure/azure_cloud_provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ func (azure *AzureCloudProvider) Name() string {

// GPULabel returns the label added to nodes with GPU resource.
func (azure *AzureCloudProvider) GPULabel() string {
return legacyGPULabel // Use legacy to avoid breaking, for now
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

legacyGPULabel is still currently used in azure_template.go to scaffold new Nodes. I elected to keep that since it doesn't seem like it would hurt anything going forward and would be one less blocker in case users try to downgrade cluster-autoscaler from 1.32 to an older version.

return GPULabel
}

// GetAvailableGPUTypes return all available GPU types cloud provider supports
Expand Down
Loading