Add ProvisioningRequestPodsFilter processor #6386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
yaroslava-serdiuk
force-pushed
the
provreq
branch
6 times, most recently
from
b821e53 to
1e1be97
Compare
kisieland
reviewed
Dec 19, 2023
cluster-autoscaler/processors/provreq/provisioning_request_pods_filter.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/processors/provreq/provisioning_request_pods_filter.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/processors/provreq/provisioning_request_pods_filter.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/processors/provreq/provisioning_request_pods_filter.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/processors/provreq/provisioning_request_pods_filter.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/processors/provreq/provisioning_request_pods_filter.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/processors/provreq/provisioning_request_pods_filter.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/processors/provreq/provisioning_request_pods_filter.go
Outdated
Show resolved
Hide resolved
yaroslava-serdiuk
force-pushed
the
provreq
branch
2 times, most recently
from
a8e12e9 to
c92c5f1
Compare
kisieland
reviewed
Dec 20, 2023
cluster-autoscaler/processors/provreq/provisioning_request_processors_test.go
Show resolved
Hide resolved
yaroslava-serdiuk
force-pushed
the
provreq
branch
2 times, most recently
from
e1afc78 to
4bfc6f7
Compare
kisieland
reviewed
Dec 20, 2023
cluster-autoscaler/processors/provreq/provisioning_request_processors_test.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/processors/provreq/provisioning_request_processors_test.go
Show resolved
Hide resolved
yaroslava-serdiuk
force-pushed
the
provreq
branch
3 times, most recently
from
febb424 to
dea3f7a
Compare
|
/lgtm |
|
@kisieland: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
yaroslava-serdiuk
changed the title
k8s-ci-robot
added
the
needs-rebase
|
Assigning, since you're already looking into this. /assign @kisieland Please assign to me (or another code owner) after LGTMing. |
|
@yaroslava-serdiuk please resolve the merge conflicts on the PR and it should be ready for review by @x13n |
x13n
requested changes
Dec 29, 2023
cluster-autoscaler/processors/provreq/provisioning_request_processors.go
Outdated
Show resolved
Hide resolved
yaroslava-serdiuk
force-pushed
the
provreq
branch
from
dea3f7a to
772f753
Compare
k8s-ci-robot
removed
the
needs-rebase
yaroslava-serdiuk
force-pushed
the
provreq
branch
2 times, most recently
from
b7672fc to
164e53f
Compare
yaroslava-serdiuk
force-pushed
the
provreq
branch
3 times, most recently
from
0633fea to
f4c0407
Compare
yaroslava-serdiuk
force-pushed
the
provreq
branch
from
f4c0407 to
1c4e6c9
Compare
x13n
reviewed
Jan 3, 2024
| @@ -250,6 +251,7 @@ var ( | |||
| "--max-graceful-termination-sec flag should not be set when this flag is set. Not setting this flag will use unordered evictor by default."+ | |||
| "Priority evictor reuses the concepts of drain logic in kubelet(https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2712-pod-priority-based-graceful-node-shutdown#migration-from-the-node-graceful-shutdown-feature)."+ | |||
| "Eg. flag usage: '10000:20,1000:100,0:60'") | |||
| provisioningRequestsEnabled = flag.Bool("enable-provisioning-requests", false, "Whether the clusterautoscaler will be handling the ProvisioningRequest CRs.") | |||
There was a problem hiding this comment.
nit: I'd avoid mentioning clusterautoscaler in the description. It is a flag to clusterautoscaler binary, so saying the flag will affect clusterautoscaler is a bit redundant.
There was a problem hiding this comment.
Yeah, the alternative is to put it in passive voice, but I don't think it's necessary. We already mention clusterautoscaler in many flags.
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: x13n, yaroslava-serdiuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/label tide/merge-method-squash |
k8s-ci-robot
added
tide/merge-method-squash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Implementation of https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/proposals/provisioning-request.md