[Site] Update provisioning admission check controller public doc with supported CA version #1666

vbhargav875 · 2024-01-29T11:18:47Z

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Update provisioning admission check controller public doc with supported CA version

Which issue(s) this PR fixes:

Fixes #1665

Special notes for your reviewer:

NONE

Does this PR introduce a user-facing change?

NONE

netlify · 2024-01-29T11:18:53Z

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name	Link
🔨 Latest commit	`cf48dfc`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/65c3bc4624fc4400085a5c1a
😎 Deploy Preview	https://deploy-preview-1666--kubernetes-sigs-kueue.netlify.app/docs/admission-check-controllers/provisioning
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

linux-foundation-easycla · 2024-01-29T11:18:53Z

The committers listed above are authorized under a signed CLA.

✅ login: vbhargav875 / name: Vijay Bhargav Eshappa (cf48dfc)

k8s-ci-robot · 2024-01-29T11:18:56Z

Welcome @vbhargav875!

It looks like this is your first PR to kubernetes-sigs/kueue 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kueue has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2024-01-29T11:18:57Z

Hi @vbhargav875. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mimowo · 2024-01-29T11:36:55Z

site/content/en/docs/admission-check-controllers/provisioning.md

@@ -10,6 +10,8 @@ The Provisioning Admission Check Controller is an Admission Check Controller des

 The controller is part of kueue. You can enable it by setting the `ProvisioningACC` feature gate. Check the [Installation](/docs/installation/#change-the-feature-gates-configuration) guide for details on feature gate configuration.

+The Provisioning Admission Check Controller is supported on [Kubernetes cluster-autoscaler](https://github.com/kubernetes/autoscaler/tree/master/cluster-autoscaler) versions 1.29 and later.


Do we have some reference to support this is 1.29+?

/cc @kisieland

I was not able to find anything in the release notes of CA 1.29. However, I see the below PR was merged on Jan 3rd 2024. The first new CA release tag that was cut after Jan 3rd was 1.29.0
kubernetes/autoscaler#6386

Also, verified that the ProvisiongRequest directory is only present in CA 1.29.0 tag and not in the previous (1.28.2) or earlier tags.

@kisieland to confirm

@kisieland gentle reminder to take a look at this PR.

Hi, sorry for the late response. I had a lot of work over last week.
The Provisioning Request CRD support in CA should be implemented in 1.30+
There are supposed to be two more PRs.
The PR that is already implemented: kubernetes/autoscaler#6451
There is one in review: kubernetes/autoscaler#6488

Although some providers, like GKE, might have an implementation, but no earlier than 1.29

Thanks for the responses @kisieland @alculquicondor . I'll keep the PR open and update it once the feature is completely available.
Let me know if the PR should be closed instead.

maybe you can say something along the lines of:
The ProvisioningRequest was added in cluster-autoscaler v1.29, but some cloud providers might not have an implementation for it.

I have updated the text. Please take a look if it looks good now.

k8s-ci-robot · 2024-01-29T11:37:11Z

@mimowo: GitHub didn't allow me to request PR reviews from the following users: kisieland.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Do we have some reference to support this is 1.29+?

/cc @kisieland

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…ted CA version

tenzen-y · 2024-02-07T17:37:26Z

/ok-to-test

tenzen-y · 2024-02-07T17:38:25Z

/cherry-pick website

CA was already supported in kueue v0.5.

k8s-infra-cherrypick-robot · 2024-02-07T17:38:27Z

@tenzen-y: once the present PR merges, I will cherry-pick it on top of website in a new PR and assign it to you.

In response to this:

/cherry-pick website

CA was already supported in kueue v0.5.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tenzen-y · 2024-02-07T17:40:34Z

/release-note-none

alculquicondor

/lgtm
/approve

k8s-ci-robot · 2024-02-07T18:32:32Z

LGTM label has been added.

Git tree hash: 0c02bfd48eacae4f0752d383a5c8dd94d1148073

k8s-ci-robot · 2024-02-07T18:32:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, vbhargav875

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~site/OWNERS~~ [alculquicondor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-infra-cherrypick-robot · 2024-02-07T18:36:58Z

@tenzen-y: new pull request created: #1704

In response to this:

/cherry-pick website

CA was already supported in kueue v0.5.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…ted CA version (kubernetes-sigs#1666)

k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 29, 2024

k8s-ci-robot requested review from denkensk and mimowo January 29, 2024 11:18

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 29, 2024

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 29, 2024

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 29, 2024

mimowo reviewed Jan 29, 2024

View reviewed changes

Update provisioning admission check controller public doc with suppor…

cf48dfc

…ted CA version

vbhargav875 force-pushed the update-provisiong-doc branch from 5af9e8f to cf48dfc Compare February 7, 2024 17:22

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 7, 2024

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 7, 2024

alculquicondor reviewed Feb 7, 2024

View reviewed changes

k8s-ci-robot assigned alculquicondor Feb 7, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2024

k8s-ci-robot merged commit 39ca969 into kubernetes-sigs:main Feb 7, 2024
6 checks passed

k8s-ci-robot added this to the v0.6 milestone Feb 7, 2024

k8s-infra-cherrypick-robot mentioned this pull request Feb 7, 2024

[website] [Site] Update provisioning admission check controller public doc with supported CA version #1704

Merged

trasc mentioned this pull request Feb 12, 2024

Cherry-picker should copy release notes #1715

Closed

3 tasks

kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024

Update provisioning admission check controller public doc with suppor…

7ab11ca

…ted CA version (kubernetes-sigs#1666)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Site] Update provisioning admission check controller public doc with supported CA version #1666

[Site] Update provisioning admission check controller public doc with supported CA version #1666

vbhargav875 commented Jan 29, 2024

netlify bot commented Jan 29, 2024 •

edited

Loading

linux-foundation-easycla bot commented Jan 29, 2024 •

edited

Loading

k8s-ci-robot commented Jan 29, 2024

k8s-ci-robot commented Jan 29, 2024

mimowo Jan 29, 2024

vbhargav875 Jan 29, 2024

alculquicondor Jan 29, 2024

vbhargav875 Feb 5, 2024

kisieland Feb 5, 2024

alculquicondor Feb 5, 2024 •

edited

Loading

vbhargav875 Feb 6, 2024

alculquicondor Feb 6, 2024

vbhargav875 Feb 7, 2024

k8s-ci-robot commented Jan 29, 2024

tenzen-y commented Feb 7, 2024

tenzen-y commented Feb 7, 2024

k8s-infra-cherrypick-robot commented Feb 7, 2024

tenzen-y commented Feb 7, 2024

alculquicondor left a comment

k8s-ci-robot commented Feb 7, 2024

k8s-ci-robot commented Feb 7, 2024

k8s-infra-cherrypick-robot commented Feb 7, 2024

		@@ -10,6 +10,8 @@ The Provisioning Admission Check Controller is an Admission Check Controller des

		The controller is part of kueue. You can enable it by setting the `ProvisioningACC` feature gate. Check the [Installation](/docs/installation/#change-the-feature-gates-configuration) guide for details on feature gate configuration.

		The Provisioning Admission Check Controller is supported on [Kubernetes cluster-autoscaler](https://github.com/kubernetes/autoscaler/tree/master/cluster-autoscaler) versions 1.29 and later.

[Site] Update provisioning admission check controller public doc with supported CA version #1666

[Site] Update provisioning admission check controller public doc with supported CA version #1666

Conversation

vbhargav875 commented Jan 29, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

netlify bot commented Jan 29, 2024 • edited Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

linux-foundation-easycla bot commented Jan 29, 2024 • edited Loading

k8s-ci-robot commented Jan 29, 2024

k8s-ci-robot commented Jan 29, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alculquicondor Feb 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jan 29, 2024

tenzen-y commented Feb 7, 2024

tenzen-y commented Feb 7, 2024

k8s-infra-cherrypick-robot commented Feb 7, 2024

tenzen-y commented Feb 7, 2024

alculquicondor left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Feb 7, 2024

k8s-ci-robot commented Feb 7, 2024

k8s-infra-cherrypick-robot commented Feb 7, 2024

netlify bot commented Jan 29, 2024 •

edited

Loading

linux-foundation-easycla bot commented Jan 29, 2024 •

edited

Loading

alculquicondor Feb 5, 2024 •

edited

Loading