Fix vpa-up.sh script by removing duplicate recommender #6151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss-yamls.sh. Tweak that script so that it can accept recommender-externalmetrics as an argument.
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbartosik, raywainman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
I'll verify that the local testcase works, sorry for the troubles. |
|
@lallydd I took a look at your PR and I think it should still work with these changes but definitely take a look if you can. |
|
I just pulled, rebuilt, and tested. Local testing still works fine, thanks. |
Closed
Shubham82
added a commit
to Shubham82/autoscaler
that referenced
this pull request
Sep 29, 2023
k8s-ci-robot
added a commit
that referenced
this pull request
Oct 4, 2023
…elease-1.0-branch Cherry pick #6151 to VPA release 1.0 branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix vpa-up.sh script by removing duplicate recommender from the vpa-process-yamls.sh. Tweak that script so that it can accept recommender-externalmetrics as an argument if someone wants to run that separately by having the script look in both the
deployande2edirectories.Having both recommenders in this list breaks vpa-up.sh, see #6141.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This fixes a small bug when running
vpa-up.sh, which is a step in the VPA release process.See #6141 for full details.
Which issue(s) this PR fixes:
Fixes #6141
Special notes for your reviewer:
I've taken a look at the PR that introduced this change and I don't think this should break anything but would love to confirm with @lallydd.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: