vertical-pod-autoscaler/hack/vpa-up.sh broken

[raywainman]

Which component are you using?:

vertical-pod-autoscaler

What did you expect to happen?:

Running vpa-up.sh as part of the VPA release completes successfully.

What happened instead?:

$ REGISTRY=gcr.io/k8s-staging-autoscaling TAG=`grep 'const VerticalPodAutoscalerVersion = ' common/version.go | cut -d '"' -f 2` ./hack/vpa-up.sh
WARNING! Using image repository from REGISTRY env variable (gcr.io/k8s-staging-autoscaling) instead of registry.k8s.io/autoscaling.
WARNING! Using tag from TAG env variable (1.0.0) instead of the default (0.14.0).
customresourcedefinition.apiextensions.k8s.io/verticalpodautoscalercheckpoints.autoscaling.k8s.io created
customresourcedefinition.apiextensions.k8s.io/verticalpodautoscalers.autoscaling.k8s.io created
WARNING! Using image repository from REGISTRY env variable (gcr.io/k8s-staging-autoscaling) instead of registry.k8s.io/autoscaling.
WARNING! Using tag from TAG env variable (1.0.0) instead of the default (0.14.0).
clusterrole.rbac.authorization.k8s.io/system:metrics-reader created
clusterrole.rbac.authorization.k8s.io/system:vpa-actor created
clusterrole.rbac.authorization.k8s.io/system:vpa-status-actor created
clusterrole.rbac.authorization.k8s.io/system:vpa-checkpoint-actor created
clusterrole.rbac.authorization.k8s.io/system:evictioner created
clusterrolebinding.rbac.authorization.k8s.io/system:metrics-reader created
clusterrolebinding.rbac.authorization.k8s.io/system:vpa-actor created
clusterrolebinding.rbac.authorization.k8s.io/system:vpa-status-actor created
clusterrolebinding.rbac.authorization.k8s.io/system:vpa-checkpoint-actor created
clusterrole.rbac.authorization.k8s.io/system:vpa-target-reader created
clusterrolebinding.rbac.authorization.k8s.io/system:vpa-target-reader-binding created
clusterrolebinding.rbac.authorization.k8s.io/system:vpa-evictioner-binding created
serviceaccount/vpa-admission-controller created
serviceaccount/vpa-recommender created
serviceaccount/vpa-updater created
clusterrole.rbac.authorization.k8s.io/system:vpa-admission-controller created
clusterrolebinding.rbac.authorization.k8s.io/system:vpa-admission-controller created
clusterrole.rbac.authorization.k8s.io/system:vpa-status-reader created
clusterrolebinding.rbac.authorization.k8s.io/system:vpa-status-reader-binding created
WARNING! Using image repository from REGISTRY env variable (gcr.io/k8s-staging-autoscaling) instead of registry.k8s.io/autoscaling.
WARNING! Using tag from TAG env variable (1.0.0) instead of the default (0.14.0).
deployment.apps/vpa-updater created
WARNING! Using image repository from REGISTRY env variable (gcr.io/k8s-staging-autoscaling) instead of registry.k8s.io/autoscaling.
WARNING! Using tag from TAG env variable (1.0.0) instead of the default (0.14.0).
deployment.apps/vpa-recommender created
Generating certs for the VPA Admission Controller in /tmp/vpa-certs.
Error adding extensions defined via -addext
40E7F7B24A7F0000:error:0580008C:x509 certificate routines:X509at_add1_attr:duplicate attribute:../crypto/x509/x509_att.c:86:
WARNING! Using image repository from REGISTRY env variable (gcr.io/k8s-staging-autoscaling) instead of registry.k8s.io/autoscaling.
WARNING! Using tag from TAG env variable (1.0.0) instead of the default (0.14.0).
deployment.apps/vpa-admission-controller created
service/vpa-webhook created
WARNING! Using image repository from REGISTRY env variable (gcr.io/k8s-staging-autoscaling) instead of registry.k8s.io/autoscaling.
WARNING! Using tag from TAG env variable (1.0.0) instead of the default (0.14.0).
Error from server (AlreadyExists): error when creating "STDIN": deployments.apps "vpa-recommender" already exists

How to reproduce it (as minimally and precisely as possible):

Run the following:

REGISTRY=gcr.io/k8s-staging-autoscaling TAG=`grep 'const VerticalPodAutoscalerVersion = ' common/version.go | cut -d '"' -f 2` ./hack/vpa-up.sh

Anything else we need to know?:

I believe this is because in this PR we added the recommender-externalmetrics-deployment component to the list of components to bring up.

The deployment YAML for this component is another recommender:
https://github.com/kubernetes/autoscaler/blob/034632a89c9d21165d9d4d96653cfea5a6e6074b/vertical-pod-autoscaler/hack/e2e/recommender-externalmetrics-deployment.yaml

[dgttm]

do you have any workaround? I have the same issue (as a requirement for gardener setup)

[raywainman]

Yeah, I removed recommender-externalmetrics-deployment from this line locally: https://github.com/kubernetes/autoscaler/blob/master/vertical-pod-autoscaler/hack/vpa-process-yamls.sh#L43