Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] feat: Rename comments, logs, structs, and vars from packet to equinix metal #6084

Closed
wants to merge 1 commit into from
Closed

[WIP] feat: Rename comments, logs, structs, and vars from packet to equinix metal #6084

wants to merge 1 commit into from

Conversation

aayushrangwala
Copy link
Contributor

@aayushrangwala aayushrangwala commented Sep 4, 2023 •
edited
Loading

What type of PR is this?

/kind cleanup
/kind documentation
/kind deprecation

What this PR does / why we need it:

Changing all the struct, variable names, comments and logs, referring from packet -> equinix metal. This PR will be a part of overall effort to completely migrate packet cloud autoscaler to equinix-metal autoscaler.

Which issue(s) this PR fixes:

Fixes #4286

Special notes for your reviewer:

Does this PR introduce a user-facing change?

No

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 4, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @aayushrangwala!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 4, 2023
displague
displague reviewed Sep 5, 2023
View reviewed changes
cluster-autoscaler/cloudprovider/packet/packet_cloud_provider.go Outdated
// ProviderName is the cloud provider name for Packet
ProviderName = "packet"
// ProviderName is the cloud provider name for Equinix Metal
ProviderName = "equinix-metal"
Copy link
Member

@displague displague Sep 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be a breaking change for users?

Copy link
Contributor Author

@aayushrangwala aayushrangwala Sep 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess, this should not be a breaking change because this variable is used to return the Name() of the provider whereas in builders of the cloud provider buildCloudProvider and builder_all its handled as both: packet and equinixmetal

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 14, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2023
@aayushrangwala aayushrangwala mentioned this pull request Sep 15, 2023
Merged
@aayushrangwala aayushrangwala force-pushed the master branch 3 times, most recently from e69a32e to 4df7942 Compare September 21, 2023 15:18
@aayushrangwala aayushrangwala changed the title Rename comments, logs, structs, and vars from packet to equinix metal feat: Rename comments, logs, structs, and vars from packet to equinix metal Sep 21, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 25, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@x13n
Copy link
Member

x13n commented Oct 10, 2023

Please update the release note to mention that you're introducing a new cloud provider and deprecating existing 'packet' in favor of the new one.

Also, is this still worked on? It looks a bit stale by now.

/assign

@aayushrangwala aayushrangwala changed the title feat: Rename comments, logs, structs, and vars from packet to equinix metal [WIP] feat: Rename comments, logs, structs, and vars from packet to equinix metal Oct 12, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 12, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aayushrangwala
Once this PR has been reviewed and has the lgtm label, please ask for approval from x13n. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 27, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 27, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 27, 2023
@aayushrangwala
Copy link
Contributor Author

Closing as the changes included in this PR
#6085

@aayushrangwala aayushrangwala mentioned this pull request Nov 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@displague displague displague left review comments

@cprivitere cprivitere Awaiting requested review from cprivitere

@x13n x13n Awaiting requested review from x13n

Assignees

@x13n x13n

Labels
area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. kind/documentation Categorizes issue or PR as related to documentation. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename all references of Packet to Equinix Metal
4 participants
@aayushrangwala @k8s-ci-robot @x13n @displague