Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename all references of Packet to Equinix Metal #4286

Closed
ipochi opened this issue Aug 27, 2021 · 9 comments · Fixed by #6085 or #6271
Closed

Rename all references of Packet to Equinix Metal #4286

ipochi opened this issue Aug 27, 2021 · 9 comments · Fixed by #6085 or #6271
Labels
area/cluster-autoscaler kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@ipochi
Copy link
Contributor

ipochi commented Aug 27, 2021

Which component hosted in this repository is this a feature for? cluster-autoscaler

Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:

Since Equinix's acquisition of Packet, other repositories and projects are being renamed from Packet to Equinix Metal in code, config and documentation.

I'd like this to happen for cluster-autoscaler/cloudprovider/packet as well.

Describe the solution you'd like.:

All references are correctly renamed from Packet to Equinix Metal.

@ipochi ipochi added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 27, 2021
@displague
Copy link
Member

One approach to this would be to persist the packet name and docs while all go packages reside in an Equinix Metal namespace. The API code would be identical since there is a common API backing the service regardless of what API URL (api.packet.net vs api.equinix.com/metal/v1) is used. Arguments and environment names, some debug messages or errors would need to use templates to provide the correct product description or variable prefix.

On the other hand, cp -a packet equinixmetal + sed isn't so terrible. Actually, I think we can get this change in much quicker. I'll PR something.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 29, 2021
@displague
Copy link
Member

displague commented Nov 29, 2021

On the other hand, cp -a packet equinixmetal + sed isn't so terrible. Actually, I think we can get this change in much quicker. I'll PR something.

I went stale on this branch. It looks like I ran into problems with the codegen. I don't see myself picking this branch back up anytime soon.

https://github.com/kubernetes/autoscaler/compare/master...displague:equinixmetal?expand=1

@displague
Copy link
Member

displague commented Dec 9, 2021

The path I took in the branch above was to create a second provider called equinixmetal. The thought was to copy all Packet provider work into an Equinix Metal provider with s/PACKET/METAL/,s/packet/equinixmetal/,s/Packet/EquinixMetal changes applied.

With #4274 released in v1.22.1, the Packet provider now honors equinixmetal://. In order to proceed with my branch, the equinixmetal provider would need to take ownership of the equinixmetal:// prefix, introduce the new METAL prefixes (env vars), and honor the legacy Packet prefixes since these can be combined with the equinixmetal:// prefixes today.

I think a shorter path would be to create a new branch or set of branches targeting this issue. These would be focused within the existing Packet provider:

  • Make "Packet" -> "Equinix Metal" text changes and "packet.(com|net)" -> "*.equinix.com" changes
  • Add support for METAL env prefixes (continuing to support the Packet prefixes, potentially deprecating them)
  • (Optional?) Rename the packet/ directory to equinixmetal/ (and rename the files, package, and functions in that directory)

The third point introduces Go API changes in an importable path. Are we ok with that? From the projects that GitHub reveals taking a dependency on this project, none seem to import the provider paths directly.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 8, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aayushrangwala
Copy link
Contributor

/reopen

@k8s-ci-robot
Copy link
Contributor

@aayushrangwala: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment