Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4340-Migrate vertical-pod-autoscaler to k8s.io/klog/v2-Part1 #4361

Merged

Conversation

mallow111
Copy link
Contributor

Details: #4340
After making the change, go mod still has klog v1.0 dependencies:

% go mod graph |grep klog

k8s.io/autoscaler/vertical-pod-autoscaler k8s.io/[email protected]
k8s.io/autoscaler/vertical-pod-autoscaler k8s.io/klog/[email protected]
k8s.io/[email protected] k8s.io/[email protected]
k8s.io/[email protected] k8s.io/[email protected]
k8s.io/[email protected] k8s.io/[email protected]
k8s.io/[email protected] k8s.io/[email protected]
k8s.io/[email protected] k8s.io/[email protected]
k8s.io/klog/[email protected] github.com/go-logr/[email protected]
k8s.io/[email protected] github.com/go-logr/[email protected]
k8s.io/[email protected] k8s.io/[email protected]
This might be caused by implicit dependencies, e.g. vertical-pod-autoscaler needs to use component-base, while k8s.io/[email protected] k8s.io/[email protected]

% go mod graph |grep vertical-pod-autoscaler
k8s.io/autoscaler/vertical-pod-autoscaler github.com/beorn7/[email protected]
k8s.io/autoscaler/vertical-pod-autoscaler github.com/golang/[email protected]
k8s.io/autoscaler/vertical-pod-autoscaler github.com/prometheus/[email protected]
k8s.io/autoscaler/vertical-pod-autoscaler github.com/prometheus/[email protected]
k8s.io/autoscaler/vertical-pod-autoscaler github.com/prometheus/[email protected]
k8s.io/autoscaler/vertical-pod-autoscaler github.com/stretchr/[email protected]
k8s.io/autoscaler/vertical-pod-autoscaler golang.org/x/[email protected]
k8s.io/autoscaler/vertical-pod-autoscaler golang.org/x/[email protected]
k8s.io/autoscaler/vertical-pod-autoscaler k8s.io/[email protected]
k8s.io/autoscaler/vertical-pod-autoscaler k8s.io/[email protected]
k8s.io/autoscaler/vertical-pod-autoscaler k8s.io/[email protected]
k8s.io/autoscaler/vertical-pod-autoscaler k8s.io/[email protected] ---> needs this dependency
k8s.io/autoscaler/vertical-pod-autoscaler k8s.io/[email protected]
k8s.io/autoscaler/vertical-pod-autoscaler k8s.io/klog/[email protected]
k8s.io/autoscaler/vertical-pod-autoscaler k8s.io/[email protected]
k8s.io/autoscaler/vertical-pod-autoscaler k8s.io/[email protected]

This PR is just to update go.mod to klog/[email protected] and make 1 file to use this new version.The reason to pick v2.9.0 is to be consistent with cluster-autoscaler's klog version: https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/go.mod#L37.

Later on will send more PRs to update modules under vertical-pod-autoscaler to use klog/v2, this way we can avoid big code change.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 29, 2021
@mallow111
Copy link
Contributor Author

@mrueg can you help to review as well, thanks!

@mallow111 mallow111 force-pushed the update-vpa-klogversion-patch1 branch from f12c109 to 63ba22d Compare September 29, 2021 16:44
Copy link
Collaborator

@jbartosik jbartosik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbartosik, mallow111

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6dee2fb into kubernetes:master Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants