Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate vertical-pod-autoscaler to k8s.io/klog/v2 #4340

Closed
mrueg opened this issue Sep 17, 2021 · 6 comments
Closed

Migrate vertical-pod-autoscaler to k8s.io/klog/v2 #4340

mrueg opened this issue Sep 17, 2021 · 6 comments
Assignees
@mallow111
Labels
area/vertical-pod-autoscaler good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@mrueg
Copy link
Member

mrueg commented Sep 17, 2021 •
edited
Loading

Which component are you using?:

vertical-pod-autoscaler

Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:

Currently vertical-pod-autoscaler uses k8s.io/klog and most packages depending on vpa have moved on to k8s.io/klog/v2.
Please migrate vpa to k8s.io/klog/v2 so the number of dependencies can get reduced. This is probably a good-first-issue for folks wanting to contribute.

Describe any alternative solutions you've considered.:
None

Additional context.:
None
@mrueg mrueg added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 17, 2021
@jbartosik jbartosik added area/vertical-pod-autoscaler good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Sep 27, 2021
@mallow111
Copy link
Contributor

/assign

@mallow111 mallow111 removed their assignment Sep 27, 2021
@mallow111
Copy link
Contributor

/assign

mallow111 pushed a commit to mallow111/autoscaler that referenced this issue Sep 29, 2021
kubernetes#4340-Migrate vertical-pod-autoscaler to k8s.io/klog/v2
5bdb6ad
@mallow111 mallow111 mentioned this issue Sep 29, 2021
Closed
mallow111 added a commit to mallow111/autoscaler that referenced this issue Sep 29, 2021
@mallow111
kubernetes#4340-Migrate vertical-pod-autoscaler to k8s.io/klog/v2-Part1
f12c109
@mallow111 mallow111 mentioned this issue Sep 29, 2021
Merged
k8s-ci-robot added a commit that referenced this issue Oct 15, 2021
@k8s-ci-robot
Merge pull request #4361 from mallow111/update-vpa-klogversion-patch1
6dee2fb 
#4340-Migrate vertical-pod-autoscaler to k8s.io/klog/v2-Part1
@mallow111 mallow111 mentioned this issue Oct 24, 2021
Merged
@jbartosik
Copy link
Collaborator

@mallow111

I took a look at the repo and I think there are a few uses of klog v1 left:

./e2e/v1/e2e.go:	"k8s.io/klog"
./e2e/v1/recommender.go:	"k8s.io/klog"
./e2e/v1beta2/e2e.go:	"k8s.io/klog"
./e2e/v1beta2/recommender.go:	"k8s.io/klog"
./pkg/updater/main.go:	"k8s.io/klog"
./pkg/recommender/model/cluster_test.go:	"k8s.io/klog"
./pkg/recommender/main.go:	"k8s.io/klog"

Do you want to remove them? I think it'd be nice to fully switch before next release (#4404).

@mallow111
Copy link
Contributor

@jbartosik I can try to fix it in the next few days.

This was referenced Dec 7, 2021
Merged
Closed
@mallow111 mallow111 mentioned this issue Dec 17, 2021
Merged
@mallow111
Copy link
Contributor

mallow111 commented Dec 20, 2021 •
edited
Loading

I guess we can close this one now, it is all done. @mrueg @jbartosik

@jbartosik
Copy link
Collaborator

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mallow111 mallow111

Labels
area/vertical-pod-autoscaler good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbartosik @mrueg @mallow111