Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudprovider: add Bizflycloud provider #4009

Merged

Conversation

lmq1999
Copy link
Contributor

@lmq1999 lmq1999 commented Apr 12, 2021

This adds a new cluster autoscaler for Bizflycloud Kubernetes Engine

P/s:
Remove new dependencies and add inline cloud provider package
Make new pull request since old pull request commited by un-emailed user

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 12, 2021
@k8s-ci-robot k8s-ci-robot requested review from piosz and towca April 12, 2021 07:12
@lmq1999
Copy link
Contributor Author

lmq1999 commented Apr 12, 2021

I need help with my sub package, it didn't go though test-and-verify process

@lmq1999
Copy link
Contributor Author

lmq1999 commented Apr 12, 2021

/assign @mwielgus

@lmq1999
Copy link
Contributor Author

lmq1999 commented Apr 12, 2021

@mwielgus Hi, can you review my change again?
I have remove dependencies and add inline package as other cloud provider.

I already edit verify file but my API package didn't pass the verifier

@mwielgus
Copy link
Contributor

Looks good, please also add your cloud provider here and we are good to go:

https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/README.md

@lmq1999
Copy link
Contributor Author

lmq1999 commented Apr 14, 2021

Looks good, please also add your cloud provider here and we are good to go:

https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/README.md

Added as you say

@mwielgus
Copy link
Contributor

Actually, there is one serious problem I have just noticed (sorry for not checking it earlier). Your cloud provider library is released under GPL(https://github.com/kubernetes/autoscaler/pull/4009/files#diff-d85a67df5ab779ac4287080d3d00b64aded31bf33207f0594c546ae51a32482c) which is not compatible with Apache license under which Cluster Autoscaler is released (https://github.com/kubernetes/autoscaler/blob/master/LICENSE).

Quote from https://www.apache.org/licenses/GPL-compatibility.html:

[...] However, GPLv3 software cannot be included in Apache projects. The licenses are incompatible in one direction only, and it is a result of ASF's licensing philosophy and the GPLv3 authors' interpretation of copyright law. [...]

So we cannot accept any Bizflycloud dependency as long as it stays under GPL. If your are employed in Bizflycloud please talk to your lawyers about possible license change.

@lmq1999
Copy link
Contributor Author

lmq1999 commented Apr 14, 2021

Actually, there is one serious problem I have just noticed (sorry for not checking it earlier). Your cloud provider library is released under GPL(https://github.com/kubernetes/autoscaler/pull/4009/files#diff-d85a67df5ab779ac4287080d3d00b64aded31bf33207f0594c546ae51a32482c) which is not compatible with Apache license under which Cluster Autoscaler is released (https://github.com/kubernetes/autoscaler/blob/master/LICENSE).

Quote from https://www.apache.org/licenses/GPL-compatibility.html:

[...] However, GPLv3 software cannot be included in Apache projects. The licenses are incompatible in one direction only, and it is a result of ASF's licensing philosophy and the GPLv3 authors' interpretation of copyright law. [...]

So we cannot accept any Bizflycloud dependency as long as it stays under GPL. If your are employed in Bizflycloud please talk to your lawyers about possible license change.

Can we use MIT license for Bizfly Cloud dependency instead of GPL. I can't ask him right now but I will talk to him later

@lmq1999
Copy link
Contributor Author

lmq1999 commented Apr 15, 2021

We have manage to change license to MIT since it also compatible with Apache 2.0 license

@lmq1999
Copy link
Contributor Author

lmq1999 commented May 3, 2021

@mwielgus Can you check the PR again, it quite long since your last review

Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmq1999, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1330ab1 into kubernetes:master May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants