-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloudprovider: add Bizflycloud provider #4009
cloudprovider: add Bizflycloud provider #4009
Conversation
I need help with my sub package, it didn't go though test-and-verify process |
/assign @mwielgus |
@mwielgus Hi, can you review my change again? I already edit verify file but my API package didn't pass the verifier |
Looks good, please also add your cloud provider here and we are good to go: https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/README.md |
Added as you say |
Actually, there is one serious problem I have just noticed (sorry for not checking it earlier). Your cloud provider library is released under GPL(https://github.com/kubernetes/autoscaler/pull/4009/files#diff-d85a67df5ab779ac4287080d3d00b64aded31bf33207f0594c546ae51a32482c) which is not compatible with Apache license under which Cluster Autoscaler is released (https://github.com/kubernetes/autoscaler/blob/master/LICENSE). Quote from https://www.apache.org/licenses/GPL-compatibility.html:
So we cannot accept any Bizflycloud dependency as long as it stays under GPL. If your are employed in Bizflycloud please talk to your lawyers about possible license change. |
Can we use MIT license for Bizfly Cloud dependency instead of GPL. I can't ask him right now but I will talk to him later |
We have manage to change license to MIT since it also compatible with Apache 2.0 license |
@mwielgus Can you check the PR again, it quite long since your last review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lmq1999, mwielgus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This adds a new cluster autoscaler for Bizflycloud Kubernetes Engine
P/s:
Remove new dependencies and add inline cloud provider package
Make new pull request since old pull request commited by un-emailed user