Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gobizflycloud go.mod breaks go mod vendor #4076

Closed
avorima opened this issue May 12, 2021 · 2 comments
Closed

gobizflycloud go.mod breaks go mod vendor #4076

avorima opened this issue May 12, 2021 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@avorima
Copy link
Contributor

avorima commented May 12, 2021

The bizflycloud provider (#4009) introduced an SDK with a go.mod that's not vendored which causes failures.

$ cd cluster-autoscaler
$ go mod vendor
go: finding module for package k8s.io/autoscaler/cluster-autoscaler/cloudprovider/bizflycloud/gobizfly
go: found k8s.io/autoscaler/cluster-autoscaler/cloudprovider/bizflycloud/gobizfly in k8s.io/autoscaler/cluster-autoscaler/cloudprovider/bizflycloud/gobizfly v0.0.0-20210511160736-2e6ccacee698
go: k8s.io/autoscaler/cluster-autoscaler/cloudprovider/bizflycloud imports
        k8s.io/autoscaler/cluster-autoscaler/cloudprovider/bizflycloud/gobizfly: k8s.io/autoscaler/cluster-autoscaler/cloudprovider/bizflycloud/[email protected]: parsing go.mod:
        module declares its path as: github.com/bizflycloud/gobizfly
                but was required as: k8s.io/autoscaler/cluster-autoscaler/cloudprovider/bizflycloud/gobizfly

My current local solution is to remove the go.mod that's causing problems.

I couldn't find the OWNERS of said cloudprovider, but pinging @lmq1999 since they contributed the code.

@avorima avorima added the kind/bug Categorizes issue or PR as related to a bug. label May 12, 2021
@towca
Copy link
Collaborator

towca commented May 12, 2021

Thanks for catching this, I was just going to create the same issue. It's also preventing us from updating vendor in the repository. I'm going to delete the go.mod file for now. @lmq1999 - I think ultimately leaving just the go source files makes the most sense, but I'll leave it up to you.

@avorima
Copy link
Contributor Author

avorima commented May 12, 2021

@towca Thanks!

@avorima avorima closed this as completed May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants