Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AWS CA tests for InstanceType generation changes #3222

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Fix AWS CA tests for InstanceType generation changes #3222

merged 1 commit into from
Jun 16, 2020

Conversation

gjtempleton
Copy link
Member

@gjtempleton gjtempleton commented Jun 15, 2020 •
edited
Loading

Updates the AWS Cloudprovider tests to match the updates to call signatures from #3185

Renamed a couple of variables for instance type overrides to be more explicitly named in the tests at the same time.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 15, 2020
@gjtempleton gjtempleton force-pushed the Update-Tests-For-InstanceTypes branch from 2f5cab7 to 63dc965 Compare June 15, 2020 08:16
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 15, 2020
@gjtempleton
Copy link
Member Author

/assign @Jeffwan

@JensErat JensErat mentioned this pull request Jun 15, 2020
Closed
@Jeffwan
Copy link
Contributor

Jeffwan commented Jun 16, 2020

/assign @Jeffwan

Jeffwan
Jeffwan approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@Jeffwan Jeffwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@Jeffwan
Copy link
Contributor

Jeffwan commented Jun 16, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit d4c5604 into kubernetes:master Jun 16, 2020
@gjtempleton gjtempleton deleted the Update-Tests-For-InstanceTypes branch June 17, 2020 08:10
This was referenced Jul 21, 2020
Merged
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Jul 21, 2020
@k8s-ci-robot
Merge pull request #3335 from gjtempleton/automated-cherry-pick-of-#3…
ba39aee 
…185-upstream-cluster-autoscaler-release-1.16

Automated cherry pick of #3185: cluster-autoscaler: use generated instance types #3222: Fix AWS CA tests for InstanceType generation changes
k8s-ci-robot added a commit that referenced this pull request Jul 21, 2020
@k8s-ci-robot
Merge pull request #3336 from gjtempleton/automated-cherry-pick-of-#3…
afce3ea 
…185-upstream-cluster-autoscaler-release-1.15

Automated cherry pick of #3185: cluster-autoscaler: use generated instance types #3222: Fix AWS CA tests for InstanceType generation change
k8s-ci-robot added a commit that referenced this pull request Jul 21, 2020
@k8s-ci-robot
Merge pull request #3334 from gjtempleton/automated-cherry-pick-of-#3…
0d7d0f4 
…185-upstream-cluster-autoscaler-release-1.17

Automated cherry pick of #3185: cluster-autoscaler: use generated instance types #3222: Fix AWS CA tests for InstanceType generation changes
k8s-ci-robot added a commit that referenced this pull request Jul 21, 2020
@k8s-ci-robot
Merge pull request #3337 from gjtempleton/automated-cherry-pick-of-#3…
13a6e8e 
…185-#3222-upstream-cluster-autoscaler-release-1.18

Automated cherry pick of #3185: cluster-autoscaler: use generated instance types #3222: Fix AWS CA tests for InstanceType generation changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeffwan Jeffwan Jeffwan approved these changes

@aleksandra-malinowska aleksandra-malinowska Awaiting requested review from aleksandra-malinowska

@losipiuk losipiuk Awaiting requested review from losipiuk

Assignees

@Jeffwan Jeffwan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gjtempleton @Jeffwan @k8s-ci-robot