Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #3185: cluster-autoscaler: use generated instance types #3222: Fix AWS CA tests for InstanceType generation changes #3335

Conversation

gjtempleton
Copy link
Member

@gjtempleton gjtempleton commented Jul 21, 2020

Cherry pick of #3185 #3222 on cluster-autoscaler-release-1.16.

#3185: cluster-autoscaler: use generated instance types
#3222: Fix AWS CA tests for InstanceType generation changes

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 21, 2020
@gjtempleton gjtempleton changed the title Automated cherry pick of #3185: cluster-autoscaler: use generated instance types Automated cherry pick of #3185: cluster-autoscaler: use generated instance types #3222: Fix AWS CA tests for InstanceType generation changes Jul 21, 2020
@Jeffwan
Copy link
Contributor

Jeffwan commented Jul 21, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2020
@k8s-ci-robot k8s-ci-robot merged commit ba39aee into kubernetes:cluster-autoscaler-release-1.16 Jul 21, 2020
@MaciekPytel
Copy link
Contributor

@gjtempleton @Jeffwan This seems to breaking tests on 1.16, blocking a planned patch release. Can you take a look and either fix or rollback this change?

The errors look like this:

# k8s.io/autoscaler/cluster-autoscaler/cloudprovider/aws [k8s.io/autoscaler/cluster-autoscaler/cloudprovider/aws.test]
cloudprovider/aws/aws_manager_test.go:305:69: undefined: newLaunchConfigurationInstanceTypeCache
cloudprovider/aws/aws_manager_test.go:544:69: undefined: newLaunchConfigurationInstanceTypeCache

@gjtempleton gjtempleton deleted the automated-cherry-pick-of-#3185-upstream-cluster-autoscaler-release-1.16 branch July 27, 2020 21:57
@gjtempleton
Copy link
Member Author

Thanks for raising, raised #3365 to resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants