Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update VPA dependencies to k8s 1.16.2 #2486

Merged
merged 7 commits into from
Oct 31, 2019
Merged

Update VPA dependencies to k8s 1.16.2 #2486

merged 7 commits into from
Oct 31, 2019

Conversation

bskiba
Copy link
Member

@bskiba bskiba commented Oct 25, 2019 •
edited
Loading

  • Adds VPA update dependencies script, based on the one from Cluster Autoscaler, to make updates work with go modules.
  • Updates dependencies to 1.16.2
  • Updates the generated API code with a code generator for version 1.16.2
  • Necessary changes to e2e tests after update
  • Small change to admission controller (Webhook -> MutatingWebhook)

Fixes #2447

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 25, 2019
@bskiba bskiba force-pushed the update branch 2 times, most recently from d4d26bc to 9daeda1 Compare October 25, 2019 15:54
@bskiba bskiba mentioned this pull request Oct 30, 2019
Closed
@tariq1890
Copy link
Contributor

tariq1890 commented Oct 30, 2019 •
edited
Loading

Any updates on this PR? Would love to see this merged :).

cc @jbartosik @MaciekPytel

@bskiba
Copy link
Member Author

bskiba commented Oct 31, 2019

@jbartosik Would you mind reviewing?

@jbartosik
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbartosik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2019
@k8s-ci-robot k8s-ci-robot merged commit 086999e into kubernetes:master Oct 31, 2019
@bskiba
Copy link
Member Author

bskiba commented Oct 31, 2019

Thanks!

This was referenced Nov 1, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbartosik jbartosik Awaiting requested review from jbartosik

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

Assignees

@jbartosik jbartosik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VerticalPodAutoscaler not compatible with k8s 1.16.x libraries
4 participants
@bskiba @tariq1890 @jbartosik @k8s-ci-robot