Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPA: bring k8s dependencies to v1.16.1 #2485

Closed

Conversation

wozniakjan
Copy link
Member

@wozniakjan wozniakjan commented Oct 25, 2019

The dependencies in VPA have been out of date for some time. This PR is trying to migrate go dep to go mod and upgrading k8s dependencies to v1.16.1.

This is branch is being used in kubernetes/kube-state-metrics#949 as an interim solution to test that PR but before merging, it would be ideal to point the dependencies back to this repo.

I am not entirely sure what I did is still desired - putting go modules to VPA sub directory, perhaps it would be better maintained at root directory. I tried to follow the layout set by go dep.

closes: #2447

@k8s-ci-robot
Copy link
Contributor

Welcome @wozniakjan!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jbartosik
You can assign the PR to them by writing /assign @jbartosik in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wozniakjan wozniakjan force-pushed the go_modules_transition branch from be3cedc to 54ce75f Compare October 25, 2019 17:15
@wozniakjan wozniakjan force-pushed the go_modules_transition branch from 54ce75f to e3d5975 Compare October 25, 2019 17:19
@wozniakjan wozniakjan force-pushed the go_modules_transition branch from 9e10008 to 835ad95 Compare October 25, 2019 20:35
@wozniakjan wozniakjan changed the title [WIP] VPA: bring k8s dependencies to v1.16.1 VPA: bring k8s dependencies to v1.16.1 Oct 25, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2019
@bskiba
Copy link
Member

bskiba commented Oct 30, 2019

✋ Looks like we worked on this simultaneously :) I'm working on getting #2486 merged. Will it will cover your needs as well?

@wozniakjan
Copy link
Member Author

awesome, thanks! I believe it should cover everything the metrics-server needs, and I will test that later this week to make sure :)

Closing this in favor of #2486

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VerticalPodAutoscaler not compatible with k8s 1.16.x libraries
3 participants