-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VPA: bring k8s dependencies to v1.16.1 #2485
Conversation
Welcome @wozniakjan! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
be3cedc
to
54ce75f
Compare
DirectCodecFactory -> WithoutConversionCodecFactory kubernetes/apimachinery@ed8af17
54ce75f
to
e3d5975
Compare
9e10008
to
835ad95
Compare
✋ Looks like we worked on this simultaneously :) I'm working on getting #2486 merged. Will it will cover your needs as well? |
awesome, thanks! I believe it should cover everything the metrics-server needs, and I will test that later this week to make sure :) Closing this in favor of #2486 |
The dependencies in VPA have been out of date for some time. This PR is trying to migrate
go dep
togo mod
and upgrading k8s dependencies to v1.16.1.This is branch is being used in kubernetes/kube-state-metrics#949 as an interim solution to test that PR but before merging, it would be ideal to point the dependencies back to this repo.
I am not entirely sure what I did is still desired - putting go modules to VPA sub directory, perhaps it would be better maintained at root directory. I tried to follow the layout set by
go dep
.closes: #2447