Upgrade CA version in aws example and fix autodiscover example #1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Jeffwan
force-pushed
the
fix_aws_examples
branch
from
9a0102e to
87d3343
Compare
Closed
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bskiba The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve two issues.
Some typos from commit e4fcef0 make Autodiscovery samples not working well. ASG can not be detected.
Not discovering ASGs on AWS #1854
Not sure why default SSL cert path has been changed in commit which makes CA fails in EKS
82162e5
EKS support for Kubernetes 1.12 has been released and I upgrade doc samples default to v1.12.3
A few users reports it's hard to configure CA in EKS, I make samples ssl ca path default to compatible with EKS-AMI. Ubuntu ssl ca path is moved to Notes.