Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: failed forbidden Jobs #1861

Merged
merged 4 commits into from
Apr 23, 2019
Merged

Fix: failed forbidden Jobs #1861

merged 4 commits into from
Apr 23, 2019

Conversation

reinaldo-pinto
Copy link
Contributor

Adding rules needed of the Jobs on file to work.

@reinaldo-pinto
Fix: failed forbidden
ca29bee 
adding rules needed of the Job on file
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 4, 2019
@bskiba
Copy link
Member

bskiba commented Apr 4, 2019

Thanks for the contribution. Please sign the CLA so we can merge this.

@Jeffwan
Copy link
Contributor

Jeffwan commented Apr 4, 2019

Can you update all examples?

mwielgus
mwielgus approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2019
@mwielgus mwielgus removed approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 9, 2019
@mwielgus
Copy link
Contributor

mwielgus commented Apr 9, 2019 •
edited
Loading

Please sign CLA.

@mwielgus
Copy link
Contributor

Friendly ping, please sign CLA.

@reinaldo-pinto
Copy link
Contributor Author

Hello my friend, already signed in CLA.
Thanks

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 15, 2019
Jeffwan
Jeffwan suggested changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@Jeffwan Jeffwan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reinaldo-pinto Can you also update other examples in example folder and make them consistent?

@reinaldo-pinto
Fix: Failed forbidden, using RBAC.
1b43a1c 
adding rules needed of the Job on file. cluster-autoscaler-autodiscover.yaml
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2019
@reinaldo-pinto
Fix: failed forbidden, using RBAC.
5c15ad5 
adding rules needed of the Job on file.  cluster-autoscaler-multi-asg.yaml
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 23, 2019
@reinaldo-pinto
Fix: failed forbidden, using RBAC.
129bc11 
adding rules needed of the Job on file.  cluster-autoscaler-run-on-master.yaml
@reinaldo-pinto
Copy link
Contributor Author

Hi, @Jeffwan I already added the changes in all files.
Thank you.

feiskyer
feiskyer reviewed Apr 23, 2019
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit 16bd851 into kubernetes:master Apr 23, 2019
@reinaldo-pinto reinaldo-pinto deleted the patch-1 branch April 23, 2019 17:53
@Jeffwan Jeffwan mentioned this pull request Aug 2, 2019
Merged
k8s-ci-robot added a commit that referenced this pull request Aug 5, 2019
@k8s-ci-robot
Merge pull request #2229 from Jeffwan/fix-1.14
755b8a6 
CA 1.14: cherry pick of #1970, #1864 and #1861
@danielmellado danielmellado mentioned this pull request Oct 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@Jeffwan Jeffwan Jeffwan requested changes

@mwielgus mwielgus mwielgus approved these changes

@losipiuk losipiuk Awaiting requested review from losipiuk

Assignees

@feiskyer feiskyer

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@reinaldo-pinto @k8s-ci-robot @bskiba @Jeffwan @mwielgus @feiskyer