Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick of #1643: Capacity prediction based on physical memory #1695

Conversation

jkaniuk
Copy link
Contributor

@jkaniuk jkaniuk commented Feb 15, 2019

Cherry-pick of #1643
with dependency on #1550

/cc aleksandra-malinowska
/cc MaciekPytel
/cc losipiuk

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 15, 2019
@losipiuk
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: losipiuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2019
@jkaniuk
Copy link
Contributor Author

jkaniuk commented Feb 15, 2019

Tested by:

  • spinning up cluster with empty autoscaling node-pool
  • adding pod with capacity 1Mi bigger than computed according to new allocatable calculations minus 220Mi (DeamonSets)
  • confirming that will not spin up a node
  • removing pod
  • adding pod with capacity computed according to new allocatable calculation minus 220Mi (DeamonSets)
  • confirming that will spin up a node
  • pod will not fit as real allocatable is slightly less (1-2MB)
  • waiting for node to be taken down as unneeded
  • confirming that no new node is added to that nodepool because of that pod (so cache is working)
  • deleting node pool
  • confirming that cluster-autoscaler handles node pool removal
  • adding new node pool with the same name
  • confirming that new node once again is spin up for given pod and new node pool (so cache is cleared)

Separately, capacity and allocatable calculations were checked against many machine-types and GKE versions 1.11 and 1.12.
Calculations for 1.13 should be the same as for 1.12.

@jkaniuk
Copy link
Contributor Author

jkaniuk commented Feb 15, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit c70f0d9 into kubernetes:cluster-autoscaler-release-1.13 Feb 15, 2019
@jkaniuk jkaniuk deleted the capacity-prediction-1.13 branch March 22, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants