Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass nodeGroup->NodeInfo map to ClusterStateRegistry #1550

Merged
merged 1 commit into from
Jan 8, 2019
Merged

Pass nodeGroup->NodeInfo map to ClusterStateRegistry #1550

merged 1 commit into from
Jan 8, 2019

Conversation

losipiuk
Copy link
Contributor

@losipiuk losipiuk commented Jan 2, 2019

No description provided.

@losipiuk losipiuk requested a review from MaciekPytel January 2, 2019 15:23
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 2, 2019
@MaciekPytel
Copy link
Contributor

MaciekPytel commented Jan 3, 2019 •
edited
Loading

Please fix gofmt presubmit.

edit: Also you'll need to fix after rebase, as GetNodeInfosForGroups now uses listers. Otherwise lgtm.

@losipiuk losipiuk force-pushed the lukaszos/pass-nodegroup-nodeinfo-map-to-clusterstateregistry-b698e branch 2 times, most recently from 9d10b14 to 6a760d2 Compare January 8, 2019 12:47
@losipiuk
Pass nodeGroup->NodeInfo map to ClusterStateRegistry
85a83b6 
Change-Id: Ie2a51694b5731b39c8a4135355a3b4c832c26801
@losipiuk losipiuk force-pushed the lukaszos/pass-nodegroup-nodeinfo-map-to-clusterstateregistry-b698e branch from 6a760d2 to 85a83b6 Compare January 8, 2019 14:52
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 8, 2019
@MaciekPytel
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MaciekPytel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2019
@k8s-ci-robot k8s-ci-robot merged commit 14ed6ec into kubernetes:master Jan 8, 2019
jkaniuk pushed a commit to jkaniuk/autoscaler that referenced this pull request Feb 13, 2019
@losipiuk @jkaniuk
Cherry-pick of kubernetes#1550: Pass nodeGroup->NodeInfo map to Clust…
f4c247f 
…erStateRegistry

Change-Id: Ie2a51694b5731b39c8a4135355a3b4c832c26801
@jkaniuk jkaniuk mentioned this pull request Feb 14, 2019
Merged
jkaniuk pushed a commit to jkaniuk/autoscaler that referenced this pull request Feb 14, 2019
@losipiuk @jkaniuk
Cherry-pick of kubernetes#1550: Pass nodeGroup->NodeInfo map to Clust…
3421046 
…erStateRegistry

Change-Id: Ie2a51694b5731b39c8a4135355a3b4c832c26801
@jkaniuk jkaniuk mentioned this pull request Feb 14, 2019
Merged
jkaniuk pushed a commit to jkaniuk/autoscaler that referenced this pull request Feb 15, 2019
@losipiuk @jkaniuk
Cherry-pick of kubernetes#1550: Pass nodeGroup->NodeInfo map to Clust…
836a7c7 
…erStateRegistry

Change-Id: Ie2a51694b5731b39c8a4135355a3b4c832c26801
@jkaniuk jkaniuk mentioned this pull request Feb 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

@aleksandra-malinowska aleksandra-malinowska Awaiting requested review from aleksandra-malinowska

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@MaciekPytel MaciekPytel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@losipiuk @MaciekPytel @k8s-ci-robot