Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dra-evolution: "constraints" vs. "requirements" #16

Closed
pohly opened this issue Jun 5, 2024 · 3 comments
Closed

dra-evolution: "constraints" vs. "requirements" #16

pohly opened this issue Jun 5, 2024 · 3 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@pohly
Copy link
Contributor

pohly commented Jun 5, 2024

#14 introduced different concepts:

  • constraints for a set of devices
  • requirements for a single device

There were concerns that this is artificial and that the naming isn't obvious. See #14 (comment). Needs further discussion.
@pohly pohly mentioned this issue Jun 5, 2024
Merged
pohly added a commit to pohly/enhancements that referenced this issue Jun 7, 2024
@pohly
DRA: revise API for Kubernetes 1.31
88feacd 
This is the result of the prototyping in
https://github.com/kubernetes-sigs/wg-device-management/tree/main/dra-evolution.

The key changes compared to 1.30 are:
- Removal of CRD support. Vendor configuration parameters
  are still supported as raw extensions of the in-tree types.
- Removal of the notion of a "device model" and a selection mechanism
  that only works for one such model. This simplifies the API.
- Instead of one claim referencing a ResourceClass, individual
  requests inside a claim now reference a DeviceClass.
- Support for "match attributes".
- Support for "management access".
- Support for selecting devices from a request in a claim for a
  container instead of exposing all devices of a claim.

Editorial changes:
- Reduced usage of the word "resource" in favor of "devices" and
  "DRA drivers".
- Removal of some out-dated text.

This revision of the KEP roughly corresponds to
https://github.com/kubernetes-sigs/wg-device-management/tree/258d109f54d3baaa48719519dec37a450a1dd5a1/dra-evolution
(= kubernetes-sigs/wg-device-management#14 with some
minor edits).

What is missing:
- renaming of ResourceSlice ->
  ResourcePool (https://github.com/kubernetes-sigs/wg-device-management/pull/28/files#r1630964004)

What was added from kubernetes-sigs/wg-device-management#26:
- ResourceClaim.Status.Allocation.NodeName -> NodeSelector
- flattening of the allocation result

Undecided:
- kubernetes-sigs/wg-device-management#26
- kubernetes-sigs/wg-device-management#16
- kubernetes-sigs/wg-device-management#18
@pohly pohly mentioned this issue Jun 7, 2024
Merged
4 tasks
@johnbelamaric
Copy link
Contributor

Personally I am leaning towards selectors and constraints. See kubernetes/enhancements#4709 (comment) and kubernetes/enhancements#4709 (comment).

pohly added a commit to pohly/enhancements that referenced this issue Jun 11, 2024
@pohly
DRA: revise API for Kubernetes 1.31
8cc3eec 
This is the result of the prototyping in
https://github.com/kubernetes-sigs/wg-device-management/tree/main/dra-evolution.

The key changes compared to 1.30 are:
- Removal of CRD support. Vendor configuration parameters
  are still supported as raw extensions of the in-tree types.
- Removal of the notion of a "device model" and a selection mechanism
  that only works for one such model. This simplifies the API.
- Instead of one claim referencing a ResourceClass, individual
  requests inside a claim now reference a DeviceClass.
- Support for "match attributes".
- Support for "management access".
- Support for selecting devices from a request in a claim for a
  container instead of exposing all devices of a claim.

Editorial changes:
- Reduced usage of the word "resource" in favor of "devices" and
  "DRA drivers".
- Removal of some out-dated text.

This revision of the KEP roughly corresponds to
https://github.com/kubernetes-sigs/wg-device-management/tree/258d109f54d3baaa48719519dec37a450a1dd5a1/dra-evolution
(= kubernetes-sigs/wg-device-management#14 with some
minor edits).

What is missing:
- renaming of ResourceSlice ->
  ResourcePool (https://github.com/kubernetes-sigs/wg-device-management/pull/28/files#r1630964004)

What was added from kubernetes-sigs/wg-device-management#26:
- ResourceClaim.Status.Allocation.NodeName -> NodeSelector
- flattening of the allocation result

Undecided:
- kubernetes-sigs/wg-device-management#26
- kubernetes-sigs/wg-device-management#16
- kubernetes-sigs/wg-device-management#18
@pohly
Copy link
Contributor Author

pohly commented Jun 11, 2024

I like that and the KEP update is using it now.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 9, 2024
@pohly pohly closed this as completed Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pohly @johnbelamaric @k8s-ci-robot @k8s-triage-robot