Add separate workqueue for unsaved PVs #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
cncf-cla: yes
jsafrane
force-pushed
the
pv-save-retry-workqueue
branch
from
f58fcf3 to
e2acbb3
Compare
jsafrane
force-pushed
the
pv-save-retry-workqueue
branch
2 times, most recently
from
4b0e843 to
dc9d3c9
Compare
jsafrane
force-pushed
the
pv-save-retry-workqueue
branch
from
dc9d3c9 to
e001d72
Compare
jsafrane
force-pushed
the
pv-save-retry-workqueue
branch
from
e001d72 to
86d0187
Compare
jsafrane
changed the title
k8s-ci-robot
added
size/XS
jsafrane
force-pushed
the
pv-save-retry-workqueue
branch
from
86d0187 to
84dad7d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/L
|
Added unit tests and removed WIP:, ready for review. |
jsafrane
force-pushed
the
pv-save-retry-workqueue
branch
from
84dad7d to
8ab08f2
Compare
wongma7
approved these changes
Mar 4, 2019
controller/controller.go
Outdated
| c.createProvisionedPVInterval = createProvisionedPVInterval | ||
| return nil | ||
| } | ||
| } | ||
|
|
||
| // CreateProvisionedPVBackoff is the configuration of exponential backoff between retries when we create a | ||
| // PV object for a provisioned volume. Defaults to linear backoff, 10 seconds 5 times. | ||
| // If PV is not saved after given number of retries, corresponding storage asset (volume) is deleted! | ||
| // Only one of CreateProvisionedPVInterval+CreateProvisionedPVRetryCount or CreateProvisionedPVBackoff | ||
| // can be used. |
There was a problem hiding this comment.
still want to deprecate this?
Deprecated: Use CreateProvisionedPVLimiter instead.
| Factor: 1, // linear backoff | ||
| Steps: controller.createProvisionedPVRetryCount, | ||
| Cap: controller.createProvisionedPVInterval, | ||
| if controller.createProvisionerPVLimiter != nil { |
There was a problem hiding this comment.
should it be default someday? is there any performance hit? I guess it does not matter as long as csi-provisioner uses it.
There was a problem hiding this comment.
I'd say eventually it should be default, but after a long deprecation period. As you wrote, csi-provisioner is going to use it and that's what matters.
|
|
||
| var _ VolumeStore = &queueStore{} | ||
|
|
||
| func NewVolumeStoreQueue( |
There was a problem hiding this comment.
need comment to pass repo-infra
|
|
||
| var _ VolumeStore = &backoffStore{} | ||
|
|
||
| func NewBackoffStore(client kubernetes.Interface, |
There was a problem hiding this comment.
need comment to pass repo-infra
jsafrane
force-pushed
the
pv-save-retry-workqueue
branch
from
8ab08f2 to
f7a8a33
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
humblec
pushed a commit
to humblec/sig-storage-lib-external-provisioner
that referenced
this pull request
Jun 18, 2020
…pansion Enable hostpath expansion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress:
CreateProvisionedPV*options?This PR yet another configuration option to run provisioning controller with a separate workqueue of unsaved PVs (their
client.CoreV1().PersistentVolumes().Create(volume)failed).The workqueue gets its limiter from provisioner, exponential backoff is expected. When a PV enters the queue, it cannot be deleted, i.e. the controller tries to create the PV even if user deleted corresponding PVC. Expectation is that API server error is a temporary hiccup that's going to be resolved quickly or the provisioner looses its leadership and exits. Unsaved PVs are lost in this case (or when the controller exits from any other reason)!
cc @wongma7 @msau42
I'd also suggest that at least
CreateProvisionedPVBackoffoption is deprecated and removed in a next release.