WIP: Save PV with exponential backoff #32
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to move PV saving to the main claim workqueue. If a PV fails to be saved to API server, controller remembers the PV and enqueues corresponding claim back to its workqueue. On the next
syncClaim
, the controller finds saved PV and tries to push it to API server again.Benefits:
Open issues:
failedProvisionThreshold
. More complicated refactoring is needed to get rid of it.CreateProvisionedPVRetryCount()
andCreateProvisionedPVInterval()
options.All these could be fixed by a new workqueue for failed PVs that would respect previous behavior. Still it's quite ugly and possibly error prone.
Fixes: kubernetes-csi/external-provisioner#94 kubernetes-csi/external-provisioner#131
cc @wongma7, any ideas?