Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Save PV with exponential backoff #32

Closed
wants to merge 1 commit into from

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Feb 21, 2019

This PR tries to move PV saving to the main claim workqueue. If a PV fails to be saved to API server, controller remembers the PV and enqueues corresponding claim back to its workqueue. On the next syncClaim, the controller finds saved PV and tries to push it to API server again.

Benefits:

  • We don't delete volumes if PV is not saved X times.
  • We have nice exponential backoff.

Open issues:

  • The exponential backoff is the same as for provisioning.
  • The controller stops trying to save the PV after failedProvisionThreshold. More complicated refactoring is needed to get rid of it.
  • It changes behavior of the provisioner and ignores CreateProvisionedPVRetryCount() and CreateProvisionedPVInterval() options.

All these could be fixed by a new workqueue for failed PVs that would respect previous behavior. Still it's quite ugly and possibly error prone.

Fixes: kubernetes-csi/external-provisioner#94 kubernetes-csi/external-provisioner#131

cc @wongma7, any ideas?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 21, 2019
@jsafrane
Copy link
Contributor Author

/close
in favor of #33

@k8s-ci-robot
Copy link
Contributor

@jsafrane: Closed this PR.

In response to this:

/close
in favor of #33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

external-provisioner should NOT issue delete calls between retries.
2 participants