obs: add library functions - 01 #251

nitishfy · 2023-09-20T12:09:36Z

Add the library functions to interact with OBS.

k8s-ci-robot · 2023-09-20T12:09:45Z

Hi @nitishfy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cpanato · 2023-09-20T13:05:29Z

obs/project.go

-	Architectures  []string         `json:"arch" xml:"arch"`
-	ReleaseTargets []ReleaseTarget  `json:"releasetarget,omitempty" xml:"releasetarget,omitempty"`
+	Architectures  []string         `json:"architectures" xml:"arch"`
+	ReleaseTargets []ReleaseTarget  `json:"releaseTarget,omitempty" xml:"releasetarget,omitempty"`


why this change?

@cpanato I proposed this change in the previous PR. JSON works in a bit different way than XML. For example, you don't have arrays in XML, but you have arrays in JSON. Because of that, I would prefer that JSON tags are called same as fields, i.e. plural and camel-case. In my opinion, in the JSON world, architectures is more natural than arch

obs/project.go

xmudrii · 2023-09-20T21:27:07Z

/ok-to-test

xmudrii · 2023-09-20T21:27:16Z

/test all

obs/project.go

nitishfy · 2023-09-21T11:37:05Z

Update: Ready for the next set of review

obs/project.go

xmudrii · 2023-09-23T09:40:48Z

/test all

xmudrii · 2023-09-24T16:59:53Z

/test all

xmudrii

Generally looks fine, some minor nits

obs/error.go

xmudrii · 2023-09-24T17:01:52Z

obs/error.go

+}
+
+func (e *APIError) Error() string {
+	return fmt.Sprintf("HTTP status %d: %s (%s)", e.HTTPStatusCode, e.XMLStatusCode, e.Message)


Does it make sense to have a different error message if HTTP status code is 0?

we generally have the message as unable to generate the request.

obs/error.go

xmudrii · 2023-09-24T18:15:48Z

/test all

nitishfy · 2023-09-24T18:22:21Z

when we are trying to build the Read function for library, what do we actually expect from it? Is it to display the Project meta?

obs/project.go

nitishfy · 2023-09-26T14:41:35Z

/test all

obs/project.go

xmudrii · 2023-09-28T07:08:37Z

/test all

xmudrii

Some lint error, please address these errors

obs/project.go

Signed-off-by: NitishKumar06 <[email protected]>

nitishfy · 2023-09-29T13:53:48Z

/test all

xmudrii

/lgtm
/approve

k8s-ci-robot · 2023-09-29T15:22:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nitishfy, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 20, 2023

k8s-ci-robot requested review from cici37 and jimangel September 20, 2023 12:09

k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 20, 2023

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 20, 2023

cpanato requested changes Sep 20, 2023

View reviewed changes

k8s-ci-robot assigned cpanato Sep 20, 2023

xmudrii reviewed Sep 20, 2023

View reviewed changes

obs/project.go Outdated Show resolved Hide resolved

obs/project.go Show resolved Hide resolved

obs/project.go Outdated Show resolved Hide resolved

obs/project.go Show resolved Hide resolved

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 20, 2023

xmudrii suggested changes Sep 20, 2023

View reviewed changes

obs/project.go Outdated Show resolved Hide resolved

k8s-ci-robot assigned xmudrii Sep 20, 2023

nitishfy requested review from xmudrii and cpanato September 21, 2023 11:37

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 21, 2023

xmudrii suggested changes Sep 23, 2023

View reviewed changes

obs/project.go Outdated Show resolved Hide resolved

obs/project.go Outdated Show resolved Hide resolved

xmudrii suggested changes Sep 23, 2023

View reviewed changes

obs/project.go Outdated Show resolved Hide resolved

obs/project.go Outdated Show resolved Hide resolved

obs/project.go Outdated Show resolved Hide resolved

xmudrii suggested changes Sep 24, 2023

View reviewed changes

xmudrii reviewed Sep 24, 2023

View reviewed changes

obs/error.go Show resolved Hide resolved

nitishfy force-pushed the Nitish/obs-crud-operations branch from 497bdfb to 462a5f7 Compare September 24, 2023 18:07

nitishfy requested a review from xmudrii September 26, 2023 10:16

xmudrii suggested changes Sep 26, 2023

View reviewed changes

xmudrii reviewed Sep 26, 2023

View reviewed changes

obs/project.go Outdated Show resolved Hide resolved

nitishfy changed the title ~~obs: add library functions~~ obs: add library functions - 01 Sep 26, 2023

nitishfy requested a review from xmudrii September 26, 2023 14:42

xmudrii suggested changes Sep 26, 2023

View reviewed changes

obs/project.go Outdated Show resolved Hide resolved

obs/project.go Outdated Show resolved Hide resolved

add initial library functions: DELETE

07ec6b9

nitishfy force-pushed the Nitish/obs-crud-operations branch from e868220 to 07ec6b9 Compare September 26, 2023 15:30

xmudrii suggested changes Sep 28, 2023

View reviewed changes

obs/project.go Outdated Show resolved Hide resolved

obs/project.go Outdated Show resolved Hide resolved

marked suggestions

78479be

Signed-off-by: NitishKumar06 <[email protected]>

nitishfy requested a review from xmudrii September 29, 2023 13:53

nitishfy marked this pull request as ready for review September 29, 2023 14:33

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2023

k8s-ci-robot requested review from justaugustus and puerco September 29, 2023 14:33

xmudrii approved these changes Sep 29, 2023

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2023

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2023

k8s-ci-robot merged commit ca307ed into kubernetes-sigs:main Sep 29, 2023

nitishfy deleted the Nitish/obs-crud-operations branch September 29, 2023 15:23

nitishfy mentioned this pull request Oct 1, 2023

REQUEST: New membership for <nitishfy> kubernetes/org#4494

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

obs: add library functions - 01 #251

obs: add library functions - 01 #251

nitishfy commented Sep 20, 2023 •

edited

Loading

k8s-ci-robot commented Sep 20, 2023

cpanato Sep 20, 2023

xmudrii Sep 20, 2023

xmudrii commented Sep 20, 2023

xmudrii commented Sep 20, 2023

nitishfy commented Sep 21, 2023

xmudrii commented Sep 23, 2023

xmudrii commented Sep 24, 2023

xmudrii left a comment

xmudrii Sep 24, 2023

nitishfy Sep 24, 2023

xmudrii commented Sep 24, 2023

nitishfy commented Sep 24, 2023

nitishfy commented Sep 26, 2023

xmudrii commented Sep 28, 2023

xmudrii left a comment

nitishfy commented Sep 29, 2023

xmudrii left a comment

k8s-ci-robot commented Sep 29, 2023

obs: add library functions - 01 #251

obs: add library functions - 01 #251

Conversation

nitishfy commented Sep 20, 2023 • edited Loading

k8s-ci-robot commented Sep 20, 2023

cpanato Sep 20, 2023

Choose a reason for hiding this comment

xmudrii Sep 20, 2023

Choose a reason for hiding this comment

xmudrii commented Sep 20, 2023

xmudrii commented Sep 20, 2023

nitishfy commented Sep 21, 2023

xmudrii commented Sep 23, 2023

xmudrii commented Sep 24, 2023

xmudrii left a comment

Choose a reason for hiding this comment

xmudrii Sep 24, 2023

Choose a reason for hiding this comment

nitishfy Sep 24, 2023

Choose a reason for hiding this comment

xmudrii commented Sep 24, 2023

nitishfy commented Sep 24, 2023

nitishfy commented Sep 26, 2023

xmudrii commented Sep 28, 2023

xmudrii left a comment

Choose a reason for hiding this comment

nitishfy commented Sep 29, 2023

xmudrii left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Sep 29, 2023

nitishfy commented Sep 20, 2023 •

edited

Loading