marked suggestions

Signed-off-by: NitishKumar06 <[email protected]>

obs/error.go

@@ -0,0 +1,22 @@
+package obs
+
+import (
+	"encoding/xml"
+	"fmt"
+)
+
+type Status struct {
+	XMLName xml.Name `json:"status" xml:"status"`
+	Code    string   `json:"code" xml:"code,attr"`
+	Summary string   `json:"summary" xml:"summary"`
+}
+
+type APIError struct {
+	HTTPStatusCode int
+	XMLStatusCode  string
+	Message        string
+}
+
+func (e *APIError) Error() string {
+	return fmt.Sprintf("HTTP status %d: %s (%s)", e.HTTPStatusCode, e.XMLStatusCode, e.Message)
+}

obs/project.go

@@ -20,8 +20,9 @@ import (
 	"bytes"
 	"encoding/xml"
 	"fmt"
+	"log"
 	"net/http"
-	"path"
+	"net/url"
 )
 
 type Project struct {
@@ -97,33 +98,21 @@ type RepositoryPath struct {
 	Repository string `json:"repository" xml:"repository,attr"`
 }
 
-type Status struct {
-	XMLName xml.Name `json:"status" xml:"status"`
-	Code    string   `json:"code" xml:"code,attr"`
-	Summary string   `json:"summary" xml:"summary"`
-}
-
-type APIError struct {
-	HTTPStatusCode int
-	XMLStatusCode  string
-	Message        string
-}
-
-func (e *APIError) Error() string {
-	return fmt.Sprintf("HTTP status %d: %s (%s)", e.HTTPStatusCode, e.XMLStatusCode, e.Message)
-}
-
 func (c Client) CreateProject(project *Project) error {
 	xmlData, err := xml.MarshalIndent(project, "", " ")
 	if err != nil {
 		return err
 	}
 
-	urlPath := path.Join(c.APIURL, "source", project.Name, "_meta")
+	urlPath, err := url.JoinPath(c.APIURL, "source", project.Name, "_meta")
+	if err != nil {
+		log.Fatal(err)
+	}
+
 	req, err := http.NewRequest("PUT", urlPath, bytes.NewBuffer(xmlData))
 	if err != nil {
 		return &APIError{
-			HTTPStatusCode: http.StatusInternalServerError,
+			HTTPStatusCode: 0,
 			XMLStatusCode:  "",
 			Message:        fmt.Sprintf("failed to generate a new request: %v", err),
 		}
@@ -135,7 +124,7 @@ func (c Client) CreateProject(project *Project) error {
 	resp, err := c.Client.Do(req)
 	if err != nil {
 		return &APIError{
-			HTTPStatusCode: resp.StatusCode,
+			HTTPStatusCode: 0,
 			XMLStatusCode:  "",
 			Message:        fmt.Sprintf("failed to make a new request: %v", err),
 		}
@@ -162,11 +151,15 @@ func (c Client) CreateProject(project *Project) error {
 }
 
 func (c Client) DeleteProject(project *Project) error {
-	urlPath := path.Join(c.APIURL, "source", project.Name)
+	urlPath, err := url.JoinPath(c.APIURL, "source", project.Name)
+	if err != nil {
+		log.Fatal(err)
+	}
+
 	req, err := http.NewRequest("DELETE", urlPath, nil)
 	if err != nil {
 		return &APIError{
-			HTTPStatusCode: http.StatusInternalServerError,
+			HTTPStatusCode: 0,
 			XMLStatusCode:  "",
 			Message:        fmt.Sprintf("failed to generate a new request: %v", err),
 		}
@@ -178,7 +171,7 @@ func (c Client) DeleteProject(project *Project) error {
 	resp, err := c.Client.Do(req)
 	if err != nil {
 		return &APIError{
-			HTTPStatusCode: resp.StatusCode,
+			HTTPStatusCode: 0,
 			XMLStatusCode:  "",
 			Message:        fmt.Sprintf("failed to make a new request: %v", err),
 		}