Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source/cpu: don't create cpu-security.tdx.total_keys label #1130

Merged
merged 1 commit into from
Apr 14, 2023
Merged

source/cpu: don't create cpu-security.tdx.total_keys label #1130

merged 1 commit into from
Apr 14, 2023

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Apr 13, 2023

Just have that as a feature for NodeFeatureRules to consume.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 13, 2023
@netlify
Copy link

netlify bot commented Apr 13, 2023

👷 Deploy Preview for kubernetes-sigs-nfd processing.

Name Link
🔨 Latest commit 560252f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/64386478e49b7900085f2f76

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 13, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2023
@netlify
Copy link

netlify bot commented Apr 13, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 3320c74
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/64392c24ef3d9d000897183a
😎 Deploy Preview https://deploy-preview-1130--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@marquiz
Copy link
Contributor Author

marquiz commented Apr 13, 2023

My original thinking with #1079 was to NOT have tdx.total_keys as a default built-in label. Just as a feature for NodeFeatureRule(s) to consume and expose. But I lost that idea during the review process. This PR kinda implements what I had in mind.

@ping @fidencio @mythi @zvonkok WDYT?

@marquiz marquiz mentioned this pull request Apr 13, 2023
Merged
fidencio
fidencio approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @marquiz!

@marquiz
Copy link
Contributor Author

marquiz commented Apr 14, 2023

/assign @zvonkok

PiotrProkop
PiotrProkop reviewed Apr 14, 2023
View reviewed changes
source/cpu/cpu.go Outdated Show resolved Hide resolved
@PiotrProkop
Copy link
Contributor

lgtm, will wait for others to comment before giving proper one!

@marquiz
source/cpu: don't create cpu-security.tdx.total_keys label
3320c74 
Just have that as a feature for NodeFeatureRules to consume.
mythi
mythi approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@mythi: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fidencio, marquiz, mythi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zvonkok
Copy link
Contributor

zvonkok commented Apr 14, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dadf77823013c8950b996c5aad1fe6f330d51332

@k8s-ci-robot k8s-ci-robot merged commit cb604b8 into kubernetes-sigs:master Apr 14, 2023
@marquiz marquiz deleted the devel/tdx branch April 14, 2023 11:24
@marquiz marquiz mentioned this pull request Apr 14, 2023
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PiotrProkop PiotrProkop PiotrProkop left review comments

@mythi mythi mythi approved these changes

@fidencio fidencio fidencio approved these changes

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

@kad kad Awaiting requested review from kad

Assignees

@zvonkok zvonkok

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marquiz @PiotrProkop @k8s-ci-robot @zvonkok @fidencio @mythi